From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C253C433E0 for ; Wed, 3 Jun 2020 19:10:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3162D2074B for ; Wed, 3 Jun 2020 19:10:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726147AbgFCTKr (ORCPT ); Wed, 3 Jun 2020 15:10:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725821AbgFCTKr (ORCPT ); Wed, 3 Jun 2020 15:10:47 -0400 Received: from ZenIV.linux.org.uk (zeniv.linux.org.uk [IPv6:2002:c35c:fd02::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D65BC08C5C0; Wed, 3 Jun 2020 12:10:47 -0700 (PDT) Received: from viro by ZenIV.linux.org.uk with local (Exim 4.93 #3 (Red Hat Linux)) id 1jgYmc-002cvf-8M; Wed, 03 Jun 2020 19:10:38 +0000 Date: Wed, 3 Jun 2020 20:10:38 +0100 From: Al Viro To: Guenter Roeck Cc: Linus Torvalds , linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC][PATCH 05/14] ia64: csum_partial_copy_nocheck(): don't abuse csum_partial_copy_from_user() Message-ID: <20200603191038.GV23230@ZenIV.linux.org.uk> References: <20200327233006.GW23230@ZenIV.linux.org.uk> <20200327233117.1031393-1-viro@ZenIV.linux.org.uk> <20200327233117.1031393-5-viro@ZenIV.linux.org.uk> <20200603153714.GA33147@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200603153714.GA33147@roeck-us.net> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 03, 2020 at 08:37:14AM -0700, Guenter Roeck wrote: > On Fri, Mar 27, 2020 at 11:31:08PM +0000, Al Viro wrote: > > From: Al Viro > > > > Just inline the call and use memcpy() instead of __copy_from_user() and > > note that the tail is precisely ia64 csum_partial(). > > > > Signed-off-by: Al Viro > > This patch results in: > > arch/ia64/lib/csum_partial_copy.c: In function 'csum_partial_copy_nocheck': > arch/ia64/lib/csum_partial_copy.c:110:9: error: implicit declaration of function 'csum_partial' > > for ia64:{defconfig, allnoconfig, tinyconfig}. Argh... Signed-off-by: Al Viro --- diff --git a/arch/ia64/lib/csum_partial_copy.c b/arch/ia64/lib/csum_partial_copy.c index 5d147a33d648..6e82e0be8040 100644 --- a/arch/ia64/lib/csum_partial_copy.c +++ b/arch/ia64/lib/csum_partial_copy.c @@ -12,7 +12,7 @@ #include #include -#include +#include /* * XXX Fixme: those 2 inlines are meant for debugging and will go away