Re: [PATCH v14 0/3] i2c: npcm7xx: add NPCM i2c controller driver

Wolfram Sang
2020-06-03T20:25:59Z

[-- Attachment #1: Type: text/plain, Size: 876 bytes --]

On Wed, May 27, 2020 at 11:08:17PM +0300, Tali Perry wrote:
> This patch set adds i2c controller support
> for the Nuvoton NPCM Baseboard Management Controller (BMC).
>
> NPCM7xx includes 16 I2C controllers. This driver operates the controller.
> This module also includes a slave mode.
>
> ---
> v14 -> v13:
> - Fix yaml example: add missing include.
> - Replace all udelay to usleep_range, except one which is called from
> irq.
> - Fix compilation error (module_platfrom_init conflict).
> - debugfs counters always updated. Counting till max value,
> then stop counting.
> - Rename bus-frequency to clock-frequency.
> - Remove unused variables.

I don't have time for a deeper review, but from what I can tell this
driver is good to go and we can fix things incrementally from now on.

Applied to for-next (will go into 5.8), thanks!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]