From: Al Viro <viro@zeniv.linux.org.uk>
To: Nathan Chancellor <natechancellor@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [git pull] misc uaccess stuff
Date: Wed, 3 Jun 2020 21:53:32 +0100 [thread overview]
Message-ID: <20200603205332.GC23230@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20200603204439.GA2649647@ubuntu-n2-xlarge-x86>
On Wed, Jun 03, 2020 at 01:44:39PM -0700, Nathan Chancellor wrote:
> > ----------------------------------------------------------------
> > Al Viro (9):
> > pselect6() and friends: take handling the combined 6th/7th args into helper
> > binfmt_elf: don't bother with __{put,copy_to}_user()
> > binfmt_elf_fdpic: don't use __... uaccess primitives
>
> This patch breaks arm32:
>
> $ make -sj"$(nproc)" ARCH=arm CROSS_COMPILE=arm-linux-gnueabi- allyesconfig fs/binfmt_elf_fdpic.o
> ...
> In file included from ./include/linux/sched/task.h:11,
> from ./include/linux/sched/signal.h:9,
> from ./include/linux/rcuwait.h:6,
> from ./include/linux/percpu-rwsem.h:7,
> from ./include/linux/fs.h:34,
> from fs/binfmt_elf_fdpic.c:11:
> ./include/linux/uaccess.h:149:1: note: declared here
> 149 | copy_to_user(void __user *to, const void *from, unsigned long n)
> | ^~~~~~~~~~~~
> fs/binfmt_elf_fdpic.c:612:7: error: too few arguments to function 'copy_to_user'
> 612 | if (copy_to_user(ent + nr, &v)) \
> | ^~~~~~~~~~~~
> fs/binfmt_elf_fdpic.c:659:2: note: in expansion of macro 'NEW_AUX_ENT'
> 659 | NEW_AUX_ENT(AT_EXECFN, bprm->exec);
> | ^~~~~~~~~~~
Linus, consider that pull request withdrawn for now, please. My apologies -
I'll push a fixed variant and resend after a week of having it sit in -next.
next prev parent reply other threads:[~2020-06-03 20:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-03 19:23 [git pull] misc uaccess stuff Al Viro
2020-06-03 20:44 ` Nathan Chancellor
2020-06-03 20:53 ` Al Viro [this message]
2020-06-03 21:02 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200603205332.GC23230@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox