From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Maxim Uvarov <maxim.uvarov@linaro.org>
Cc: linux-kernel@vger.kernel.org, tee-dev@lists.linaro.org,
peterhuewe@gmx.de, jgg@ziepe.ca, gregkh@linuxfoundation.org,
jens.wiklander@linaro.org, linux-integrity@vger.kernel.org,
arnd@linaro.org, sumit.garg@linaro.org
Subject: Re: [PATCHv6 1/3] optee: use uuid for sysfs driver entry
Date: Thu, 4 Jun 2020 11:36:55 +0300 [thread overview]
Message-ID: <20200604083655.GA4026@linux.intel.com> (raw)
In-Reply-To: <20200601150645.13412-2-maxim.uvarov@linaro.org>
On Mon, Jun 01, 2020 at 06:06:43PM +0300, Maxim Uvarov wrote:
> With the evolving use-cases for TEE bus, now it's required to support
> multi-stage enumeration process. But using a simple index doesn't
> suffice this requirement and instead leads to duplicate sysfs entries.
> So instead switch to use more informative device UUID for sysfs entry
> like:
> /sys/bus/tee/devices/optee-ta-<uuid>
>
> Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org>
> Reviewed-by: Sumit Garg <sumit.garg@linaro.org>
Why do you mean by duplicate sysfs entries?
> ---
> Documentation/ABI/testing/sysfs-bus-optee-devices | 8 ++++++++
> MAINTAINERS | 1 +
> drivers/tee/optee/device.c | 6 +++---
> 3 files changed, 12 insertions(+), 3 deletions(-)
> create mode 100644 Documentation/ABI/testing/sysfs-bus-optee-devices
>
> diff --git a/Documentation/ABI/testing/sysfs-bus-optee-devices b/Documentation/ABI/testing/sysfs-bus-optee-devices
> new file mode 100644
> index 000000000000..0ae04ae5374a
> --- /dev/null
> +++ b/Documentation/ABI/testing/sysfs-bus-optee-devices
> @@ -0,0 +1,8 @@
> +What: /sys/bus/tee/devices/optee-ta-<uuid>/
> +Date: May 2020
> +KernelVersion 5.7
> +Contact: tee-dev@lists.linaro.org
> +Description:
> + OP-TEE bus provides reference to registered drivers under this directory. The <uuid>
> + matches Trusted Application (TA) driver and corresponding TA in secure OS. Drivers
> + are free to create needed API under optee-ta-<uuid> directory.
> diff --git a/MAINTAINERS b/MAINTAINERS
> index ecc0749810b0..6717afef2de3 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -12516,6 +12516,7 @@ OP-TEE DRIVER
> M: Jens Wiklander <jens.wiklander@linaro.org>
> L: tee-dev@lists.linaro.org
> S: Maintained
> +F: Documentation/ABI/testing/sysfs-bus-optee-devices
> F: drivers/tee/optee/
>
> OP-TEE RANDOM NUMBER GENERATOR (RNG) DRIVER
> diff --git a/drivers/tee/optee/device.c b/drivers/tee/optee/device.c
> index e3a148521ec1..ed3d1ddfa52b 100644
> --- a/drivers/tee/optee/device.c
> +++ b/drivers/tee/optee/device.c
> @@ -65,7 +65,7 @@ static int get_devices(struct tee_context *ctx, u32 session,
> return 0;
> }
>
> -static int optee_register_device(const uuid_t *device_uuid, u32 device_id)
> +static int optee_register_device(const uuid_t *device_uuid)
> {
> struct tee_client_device *optee_device = NULL;
> int rc;
> @@ -75,7 +75,7 @@ static int optee_register_device(const uuid_t *device_uuid, u32 device_id)
> return -ENOMEM;
>
> optee_device->dev.bus = &tee_bus_type;
> - dev_set_name(&optee_device->dev, "optee-clnt%u", device_id);
> + dev_set_name(&optee_device->dev, "optee-ta-%pUl", device_uuid);
This code is and already was broken. If dev_set_name() returns -ENOMEM,
the name will be a null pointer.
Also, I don't get how you can just swap the name without potentially
breaking the backwards compatiblity towards the user space.
/Jarkko
next prev parent reply other threads:[~2020-06-04 8:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-01 15:06 [PATCHv6 0/3] optee: register drivers on optee bus Maxim Uvarov
2020-06-01 15:06 ` [PATCHv6 1/3] optee: use uuid for sysfs driver entry Maxim Uvarov
2020-06-04 8:36 ` Jarkko Sakkinen [this message]
2020-06-04 9:16 ` Maxim Uvarov
2020-06-16 20:13 ` Jarkko Sakkinen
2020-06-04 9:21 ` Sumit Garg
2020-06-16 20:15 ` Jarkko Sakkinen
2020-06-01 15:06 ` [PATCHv6 2/3] optee: enable support for multi-stage bus enumeration Maxim Uvarov
2020-06-01 15:06 ` [PATCHv6 3/3] tpm_ftpm_tee: register driver on TEE bus Maxim Uvarov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200604083655.GA4026@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=arnd@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=jens.wiklander@linaro.org \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxim.uvarov@linaro.org \
--cc=peterhuewe@gmx.de \
--cc=sumit.garg@linaro.org \
--cc=tee-dev@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).