public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Kent Gibson <warthog618@gmail.com>
To: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	linux-gpio <linux-gpio@vger.kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v2] gpiolib: split character device into gpiolib-cdev
Date: Fri, 5 Jun 2020 07:30:43 +0800	[thread overview]
Message-ID: <20200604233043.GA8913@sol> (raw)
In-Reply-To: <CAMpxmJXyVO4unLQOzC0xf47CTmK6VurTk+Q=9RDWhcP0pu73pQ@mail.gmail.com>

On Thu, Jun 04, 2020 at 06:22:43PM +0200, Bartosz Golaszewski wrote:
> czw., 4 cze 2020 o 16:18 Kent Gibson <warthog618@gmail.com> napisał(a):
> >
> > >
> > > Is this comment relevant for the character device?
> > >
> >
> > True - that comment should stay in gpiolib, and gpiolib-cdev should get
> > one of it's own.
> >
> > Any suggestions on how to maintain line history?
> > I know you can trick git by moving the original file into two new ones,
> > then moving one of those back to the old name, but not sure if that is
> > what you would want to see in a patch.
> >
> 
> People don't seem to care much about this in the kernel. Files get
> moved and git blame results get lost all the time. Don't stress about
> it.
> 

Oh, ok.  I guess that explains why I couldn't find any examples of how
to do it in a patch - I had thought I wasn't looking hard enough.

There are still a couple of commits in gpio/fixes that will conflict -
are those getting merged into gpio/devel any time soon?
Or is there another branch I should rebase onto?

Cheers,
Kent.

  reply	other threads:[~2020-06-04 23:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-02 14:10 [PATCH v2] gpiolib: split character device into gpiolib-cdev Kent Gibson
2020-06-04 12:04 ` Bartosz Golaszewski
2020-06-04 14:18   ` Kent Gibson
2020-06-04 16:22     ` Bartosz Golaszewski
2020-06-04 23:30       ` Kent Gibson [this message]
2020-06-05  9:26         ` Bartosz Golaszewski
2020-06-10  9:13 ` Linus Walleij
2020-06-10  9:14   ` Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200604233043.GA8913@sol \
    --to=warthog618@gmail.com \
    --cc=bgolaszewski@baylibre.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox