From: Kees Cook <keescook@chromium.org>
To: Joe Perches <joe@perches.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: Add test for possible misuse of IS_ENABLED() without CONFIG_
Date: Fri, 5 Jun 2020 11:48:10 -0700 [thread overview]
Message-ID: <202006051148.DA853DA@keescook> (raw)
In-Reply-To: <e7fda760b91b769ba82844ba282d432c0d26d709.camel@perches.com>
On Fri, Jun 05, 2020 at 11:24:43AM -0700, Joe Perches wrote:
> IS_ENABLED is almost always used with CONFIG_<FOO> defines.
>
> Add a test to verify that the #define being tested starts with CONFIG_.
>
> Signed-off-by: Joe Perches <joe@perches.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
next prev parent reply other threads:[~2020-06-05 18:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-05 14:19 [PATCH] drm/i915: Fix comments mentioning typo in IS_ENABLED() Kees Cook
2020-06-05 14:40 ` [Intel-gfx] " Chris Wilson
2020-06-05 18:24 ` [PATCH] checkpatch: Add test for possible misuse of IS_ENABLED() without CONFIG_ Joe Perches
2020-06-05 18:48 ` Kees Cook [this message]
2020-06-06 0:32 ` Andrew Morton
2020-06-06 1:58 ` Joe Perches
2020-06-06 9:41 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202006051148.DA853DA@keescook \
--to=keescook@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox