From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B832DC433E2 for ; Fri, 5 Jun 2020 14:20:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 85DF92077D for ; Fri, 5 Jun 2020 14:20:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591366829; bh=CKtD8J02zi1GXn5FojkAwD2VlMui6Y5z2va8/XDci2k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=bS6MfjziJfBA9EBfjBeYcnkWCRFzbj5XUw+iUrxUkAQy2tngXW3Eqc4Qr+7xZl68l dO8lsEYfuL6K6vUKSXrZ0voXhgjwkx8l5ZT/5s6GJ6SKpRfMMDNQTIdIX5urZ6APFT Tu4/1EKpJ8dweqTvr5h1YvPSulUX1Ex4abxWxio8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728961AbgFEOU2 (ORCPT ); Fri, 5 Jun 2020 10:20:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:51060 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728345AbgFEOT7 (ORCPT ); Fri, 5 Jun 2020 10:19:59 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CB7AB21527; Fri, 5 Jun 2020 14:19:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591366799; bh=CKtD8J02zi1GXn5FojkAwD2VlMui6Y5z2va8/XDci2k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=0K6f6RW0Fqvtm3MDetLW68sDyt2jUbykzflPdFAx1EVg0jpc7j6riFPUhDwAyN6Xl KtZss7ND58FHuyfcl8mYYp1i1611J09u86ngpRUvIdKV/znAHgc2p8VUo2qb91vXKs OwNAuU8/q4jNun2TxGIycYGQVMd5H1h2anQEHxo8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jeremy Kerr , Stan Johnson , Finn Thain , "David S. Miller" , Sasha Levin Subject: [PATCH 4.19 22/28] net: bmac: Fix read of MAC address from ROM Date: Fri, 5 Jun 2020 16:15:24 +0200 Message-Id: <20200605140253.688243498@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200605140252.338635395@linuxfoundation.org> References: <20200605140252.338635395@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jeremy Kerr [ Upstream commit ef01cee2ee1b369c57a936166483d40942bcc3e3 ] In bmac_get_station_address, We're reading two bytes at a time from ROM, but we do that six times, resulting in 12 bytes of read & writes. This means we will write off the end of the six-byte destination buffer. This change fixes the for-loop to only read/write six bytes. Based on a proposed fix from Finn Thain . Signed-off-by: Jeremy Kerr Reported-by: Stan Johnson Tested-by: Stan Johnson Reported-by: Finn Thain Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/apple/bmac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/apple/bmac.c b/drivers/net/ethernet/apple/bmac.c index 6a8e2567f2bd..ab6ce85540b8 100644 --- a/drivers/net/ethernet/apple/bmac.c +++ b/drivers/net/ethernet/apple/bmac.c @@ -1181,7 +1181,7 @@ bmac_get_station_address(struct net_device *dev, unsigned char *ea) int i; unsigned short data; - for (i = 0; i < 6; i++) + for (i = 0; i < 3; i++) { reset_and_select_srom(dev); data = read_srom(dev, i + EnetAddressOffset/2, SROMAddressBits); -- 2.25.1