From: matthias.bgg@kernel.org
To: gregkh@linuxfoundation.org, rafael@kernel.org
Cc: linux-kernel@vger.kernel.org, gene.chen.richtek@gmail.com,
lee.jones@linaro.org, matthias.bgg@kernel.org,
Matthias Brugger <mbrugger@suse.com>,
kernel test robot <lkp@intel.com>
Subject: [PATCH 1/2] drivers: base: Warn if driver name is not present
Date: Mon, 8 Jun 2020 11:52:16 +0200 [thread overview]
Message-ID: <20200608095217.21162-1-matthias.bgg@kernel.org> (raw)
From: Matthias Brugger <mbrugger@suse.com>
If we pass a driver without a name, we end up in a NULL pointer
derefernce. Check for the name before trying to register the driver.
As we don't have a driver name to point to in the error message, we dump
the call stack to make it easier to detect the buggy driver.
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Matthias Brugger <mbrugger@suse.com>
---
drivers/base/driver.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/base/driver.c b/drivers/base/driver.c
index 57c68769e157..40fba959c140 100644
--- a/drivers/base/driver.c
+++ b/drivers/base/driver.c
@@ -149,6 +149,12 @@ int driver_register(struct device_driver *drv)
int ret;
struct device_driver *other;
+ if (!drv->name) {
+ pr_err("Driver has no name.\n");
+ dump_stack();
+ return -EINVAL;
+ }
+
if (!drv->bus->p) {
pr_err("Driver '%s' was unable to register with bus_type '%s' because the bus was not initialized.\n",
drv->name, drv->bus->name);
--
2.26.2
next reply other threads:[~2020-06-08 9:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-08 9:52 matthias.bgg [this message]
2020-06-08 9:52 ` [PATCH 2/2] drivers: base: Convert to printk alias functions matthias.bgg
2020-06-08 10:57 ` [PATCH 1/2] drivers: base: Warn if driver name is not present Greg KH
2020-06-08 11:48 ` Matthias Brugger
2020-06-08 12:15 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200608095217.21162-1-matthias.bgg@kernel.org \
--to=matthias.bgg@kernel.org \
--cc=gene.chen.richtek@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mbrugger@suse.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox