Re: [PATCH v2 1/4] selftests/livepatch: simplify test-klp-callbacks busy target tests

Petr Mladek
2020-06-05T12:58:35Z

On Wed 2020-06-03 14:20:55, Yannick Cote wrote:
> From: Joe Lawrence <joe.lawrence@redhat.com>
>
> The test-klp-callbacks script includes a few tests which rely on kernel
> task timings that may not always execute as expected under system load.
> These may generate out of sequence kernel log messages that result in
> test failure.
>
> Instead of using sleep timing windows to orchestrate these tests, add a
> block_transition module parameter to communicate the test purpose and
> utilize flush_queue() to serialize the test module's task output.
>
> Suggested-by: Petr Mladek <pmladek@suse.com>

I am not sure if I deserve this. I suggested only few implementation details.

> Signed-off-by: Joe Lawrence <joe.lawrence@redhat.com>

Looks good now:

Reviewed-by: Petr Mladek <pmladek@suse.com>

Best Regards,
Petr