Re: [PATCH] mptcp: bugfix for RM_ADDR option parsing

Geliang Tang
2020-06-08T11:01:49Z

On Mon, Jun 08, 2020 at 12:10:23PM +0200, Matthieu Baerts wrote:
> Hi Geliang,
>
> On 08/06/2020 09:48, Geliang Tang wrote:
> > In MPTCPOPT_RM_ADDR option parsing, the pointer "ptr" pointed to the
> > "Subtype" octet, the pointer "ptr+1" pointed to the "Address ID" octet:
> >
> > +-------+-------+---------------+
> > |Subtype|(resvd)| Address ID |
> > +-------+-------+---------------+
> > | |
> > ptr ptr+1
> >
> > We should set mp_opt->rm_id to the value of "ptr+1", not "ptr". This patch
> > will fix this bug.
>
> Thank you for the patch, good catch!
> Indeed "ptr" should be incremented.
>
> Because this is a bug-fix for net, may you clearly indicate that in the
> subject to help -net maintainers please? [PATCH net v2]
>
> Also, may you add a "Fixes" tag as well as it is for -net ? I guess it
> should be:
>
> Fixes: 3df523ab582c ("mptcp: Add ADD_ADDR handling")
>
> The rest is good!
>
> Cheers,
> Matt
> --
> Matthieu Baerts | R&D Engineer
> matthieu.baerts@tessares.net
> Tessares SA | Hybrid Access Solutions
> www.tessares.net
> 1 Avenue Jean Monnet, 1348 Louvain-la-Neuve, Belgium

Hi Matt,

Thanks for your reply.

I have already resend patch v2 to you.

-Geliang