Re: [PATCH v3] f2fs: use kfree() instead of kvfree() to free superblock data

Jaegeuk Kim
2020-06-15T17:58:04Z

On 06/09, Eric Biggers wrote:
> On Wed, Jun 10, 2020 at 01:14:46AM +0300, Denis Efremov wrote:
> > Use kfree() instead of kvfree() to free super in read_raw_super_block()
> > because the memory is allocated with kzalloc() in the function.
> > Use kfree() instead of kvfree() to free sbi, raw_super in
> > f2fs_fill_super() and f2fs_put_super() because the memory is allocated
> > with kzalloc().
> >
> > Fixes: 5222595d093e ("f2fs: use kvmalloc, if kmalloc is failed")
> > Signed-off-by: Denis Efremov <efremov@linux.com>
>
> I don't think "Fixes" is appropriate here.

Agreed. I queued this Cl without it. :)
Thanks,

>
> kvfree() still works on kmalloc'ed memory; it's just not preferred.
>
> So this is more a cleanup than a fix.
>
> - Eric