From: Dan Carpenter <dan.carpenter@oracle.com>
To: John Hubbard <jhubbard@nvidia.com>
Cc: "Souptick Joarder" <jrdr.linux@gmail.com>,
"open list:ANDROID DRIVERS" <devel@driverdev.osuosl.org>,
"Bharath Vedartham" <linux.bhar@gmail.com>,
harshjain32@gmail.com, "Greg KH" <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
"Simon Sandström" <simon@nikanor.nu>,
jane.pnx9@gmail.com
Subject: Re: [PATCH] staging: kpc2000: kpc_dma: Convert get_user_pages() --> pin_user_pages()
Date: Mon, 8 Jun 2020 22:16:35 +0300 [thread overview]
Message-ID: <20200608191635.GA30374@kadam> (raw)
In-Reply-To: <5f0c68a0-2cc4-5724-d778-7e9d5fd7dfde@nvidia.com>
On Mon, Jun 08, 2020 at 12:05:57PM -0700, John Hubbard wrote:
> On 2020-06-08 12:01, Souptick Joarder wrote:
> > On Mon, Jun 1, 2020 at 7:15 AM John Hubbard <jhubbard@nvidia.com> wrote:
> > >
> > > On 2020-05-31 10:51, Souptick Joarder wrote:
> > > > In 2019, we introduced pin_user_pages*() and now we are converting
> > > > get_user_pages*() to the new API as appropriate. [1] & [2] could
> > > > be referred for more information.
> > > >
> > > > When pin_user_pages() returns numbers of partially mapped pages,
> > > > those pages were not unpinned as part of error handling. Fixed
> > > > it as part of this patch.
> > > >
> > >
> > > Hi Souptick,
> > >
> > > btw, Bharath (+cc) attempted to do the "put" side of this, last year.
> > > That got as far as a v4 patch [1], and then I asked him to let me put
> > > it into my tree. But then it didn't directly apply anymore after the
> > > whole design moved to pin+unpin, and so here we are now.
> > >
> > >
> > > If Bharath is still doing kernel work, you might offer him a Co-Developed-by:
> > > tag (see https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html).
> >
> > Sure, will add him as *Co-Developed-by*
> > >
>
>
> Yes, but it's best to wait and see if he responds, before adding that tag, because
> it also required a Signed-off-by from him.
Souptick is porting patches from your tree? It's not clear to me how
Bharath actually helped author this patch.
regards,
dan carpenter
next prev parent reply other threads:[~2020-06-08 19:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-31 17:51 [PATCH] staging: kpc2000: kpc_dma: Convert get_user_pages() --> pin_user_pages() Souptick Joarder
2020-06-01 1:44 ` John Hubbard
2020-06-08 19:01 ` Souptick Joarder
2020-06-08 19:05 ` John Hubbard
2020-06-08 19:16 ` Dan Carpenter [this message]
2020-06-08 19:22 ` John Hubbard
2020-06-08 19:14 ` Dan Carpenter
2020-06-08 19:33 ` Souptick Joarder
2020-06-08 19:55 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200608191635.GA30374@kadam \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=harshjain32@gmail.com \
--cc=jane.pnx9@gmail.com \
--cc=jhubbard@nvidia.com \
--cc=jrdr.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux.bhar@gmail.com \
--cc=simon@nikanor.nu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox