Re: [PATCH AUTOSEL 4.14 72/72] string.h: fix incompatibility between FORTIFY_SOURCE and KASAN

Pavel Machek
2020-06-09T13:55:21Z

[-- Attachment #1: Type: text/plain, Size: 1385 bytes --]

On Tue 2020-06-09 13:54:07, Greg KH wrote:
> On Tue, Jun 09, 2020 at 01:20:25PM +0200, Pavel Machek wrote:
> > On Tue 2020-06-09 09:46:08, Daniel Axtens wrote:
> > > Hi Sasha,
> > >
> > > There's nothing inherently wrong with these patches being backported,
> > > but they fix a bug that doesn't cause a crash and only affects debug
> > > kernels compiled with KASAN and FORTIFY_SOURCE. Personally I wouldn't
> > > change a core header file in a stable kernel for that. Perhaps I'm too
> > > risk-averse.
> >
> > You are in agreement with existing documentation -- stable is only for
> > serious bugs.
>
> No, lots of people run KASAN on those kernels when they are testing
> their devices, this patch is fine.

Documentation currently says:

- It must fix a problem that causes a build error (but not for things
marked CONFIG_BROKEN), an oops, a hang, data corruption, a real
security issue, or some "oh, that's not good" issue. In short,
something critical.

...but we also get various warning fixes (sometimes for external
tools), changes to make printk()s less verbose, changes to make
debugging easier, etc...

Could the documentation be updated to match current use?

Thanks,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]