From: Kees Cook <keescook@chromium.org>
To: Xiaoming Ni <nixiaoming@huawei.com>
Cc: ebiederm@xmission.com, ak@linux.intel.com,
alex.huangjianhui@huawei.com, linzichang@huawei.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sysctl: Delete the code of sys_sysctl
Date: Tue, 9 Jun 2020 08:40:36 -0700 [thread overview]
Message-ID: <202006090839.6EDB4BA@keescook> (raw)
In-Reply-To: <1591683605-8585-1-git-send-email-nixiaoming@huawei.com>
On Tue, Jun 09, 2020 at 02:20:05PM +0800, Xiaoming Ni wrote:
> Since the commit 61a47c1ad3a4dc ("sysctl: Remove the sysctl system call"),
> sys_sysctl has lost its actual role: any input can only return an error.
>
> Delete the code and return -ENOSYS directly at the function entry
>
> Signed-off-by: Xiaoming Ni <nixiaoming@huawei.com>
Looks right to me.
Reviewed-by: Kees Cook <keescook@chromium.org>
Should this be taken a step further and just remove the syscall entirely
and update the per-arch tables with the ENOSYS hole?
-Kees
--
Kees Cook
next prev parent reply other threads:[~2020-06-09 15:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-09 6:20 [PATCH] sysctl: Delete the code of sys_sysctl Xiaoming Ni
2020-06-09 15:40 ` Kees Cook [this message]
2020-06-10 14:17 ` Xiaoming Ni
2020-06-10 15:03 ` Kees Cook
2020-06-09 19:20 ` Eric W. Biederman
2020-06-10 14:19 ` Xiaoming Ni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202006090839.6EDB4BA@keescook \
--to=keescook@chromium.org \
--cc=ak@linux.intel.com \
--cc=alex.huangjianhui@huawei.com \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linzichang@huawei.com \
--cc=nixiaoming@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox