Re: [PATCH v4 28/37] memory: tegra: Register as interconnect provider

Dmitry Osipenko
2020-07-03T08:41:22Z

02.07.2020 15:36, Georgi Djakov пишет:
...
>>>> + mc->provider.data = data;
>>>> + mc->provider.xlate = of_icc_xlate_onecell;
>>>> + mc->provider.aggregate = tegra_mc_icc_aggregate;
>>>> +
>>>> + err = icc_provider_add(&mc->provider);
>>>> + if (err)
>>>> + goto err_msg;
>>>
>>> Nit: I am planning to re-organize some of the existing drivers to call
>>> icc_provider_add() after the topology is populated. Could you please move
>>> this after the nodes are created and linked.
>>
>> Are you planning to remove the provider's list-head initialization from
>> the icc_provider_add() [1] and move it to the individual provider
>> drivers, correct?
>
> Yes, that would be the first step, but i need to post some patches first,
> so let's keep it as-is for now. Sorry for the confusion.

No problems, I'll keep an eye on the ICC core changes!
Please feel free to the CC me on the patches, I may give them a whirl.