Re: [PATCH v4 11/37] PM / devfreq: tegra30: Silence deferred probe error

Dmitry Osipenko
2020-07-02T01:25:16Z

02.07.2020 04:34, Chanwoo Choi пишет:
> On 7/2/20 10:20 AM, Dmitry Osipenko wrote:
>> 02.07.2020 03:59, Chanwoo Choi пишет:
>>> Hi,
>>>
>>> On 6/9/20 10:13 PM, Dmitry Osipenko wrote:
>>>> Tegra EMC driver was turned into a regular kernel driver, it also could
>>>> be compiled as a loadable kernel module now. Hence EMC clock isn't
>>>> guaranteed to be available and clk_get("emc") may return -EPROBE_DEFER and
>>>> there is no good reason to spam KMSG with a error about missing EMC clock
>>>> in this case, so let's silence the deferred probe error.
>>>>
>>>> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
>>>> ---
>>>> drivers/devfreq/tegra30-devfreq.c | 9 ++++++---
>>>> 1 file changed, 6 insertions(+), 3 deletions(-)
>>>>
>>>> diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c
>>>> index e94a27804c20..423dd35c95b3 100644
>>>> --- a/drivers/devfreq/tegra30-devfreq.c
>>>> +++ b/drivers/devfreq/tegra30-devfreq.c
>>>> @@ -801,9 +801,12 @@ static int tegra_devfreq_probe(struct platform_device *pdev)
>>>> }
>>>>
>>>> tegra->emc_clock = devm_clk_get(&pdev->dev, "emc");
>>>> - if (IS_ERR(tegra->emc_clock)) {
>>>> - dev_err(&pdev->dev, "Failed to get emc clock\n");
>>>> - return PTR_ERR(tegra->emc_clock);
>>>> + err = PTR_ERR_OR_ZERO(tegra->emc_clock);
>>>> + if (err) {
>>>> + if (err != -EPROBE_DEFER)
>>>> + dev_err(&pdev->dev, "Failed to get emc clock: %d\n",
>>>> + err);
>>>> + return err;
>>>> }
>>>>
>>>> err = platform_get_irq(pdev, 0);
>>>>
>>>
>>> As I commented on patch10, I recommend that you add the Tegra EMC driver
>>> commit information into patch description and Looks good to me.
>>>
>>
>> Hello, Chanwoo!
>>
>> This patch11 and patch10 are depending on the patches 4/5 (the Tegra EMC
>> driver patches) of *this* series, hence there is no commit information.
>> I'm expecting that this whole series will go via tegra tree once all the
>> patches will be reviewed and collect all the necessary acks from you,
>> ICC and CLK subsystem maintainers.
>>
>> Please feel free to give yours ack to the patches 10/11 if they are good
>> to you :)
>>
>>
>
> OK. Looks good to me
> Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
>

Thank you! :)