* [PATCH 1/2] perf parse-events: fix an incompatible pointer
@ 2020-06-09 5:36 Ian Rogers
2020-06-09 5:36 ` [PATCH 2/2] perf parse-events: fix an old style declaration Ian Rogers
2020-06-09 15:36 ` [PATCH 1/2] perf parse-events: fix an incompatible pointer Arnaldo Carvalho de Melo
0 siblings, 2 replies; 4+ messages in thread
From: Ian Rogers @ 2020-06-09 5:36 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Mark Rutland, Alexander Shishkin, Jiri Olsa, Namhyung Kim,
Andi Kleen, linux-kernel
Cc: Stephane Eranian, Ian Rogers
Arrays are pointer types and don't need their address taking.
Fixes: 8255718f4bed (perf pmu: Expand PMU events by prefix match)
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/util/parse-events.y | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/parse-events.y b/tools/perf/util/parse-events.y
index c4ca932d092d..d4e076c9c2ab 100644
--- a/tools/perf/util/parse-events.y
+++ b/tools/perf/util/parse-events.y
@@ -349,7 +349,7 @@ PE_PMU_EVENT_PRE '-' PE_PMU_EVENT_SUF sep_dc
struct list_head *list;
char pmu_name[128];
- snprintf(&pmu_name, 128, "%s-%s", $1, $3);
+ snprintf(pmu_name, sizeof(pmu_name), "%s-%s", $1, $3);
free($1);
free($3);
if (parse_events_multi_pmu_add(_parse_state, pmu_name, &list) < 0)
--
2.27.0.278.ge193c7cf3a9-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] perf parse-events: fix an old style declaration
2020-06-09 5:36 [PATCH 1/2] perf parse-events: fix an incompatible pointer Ian Rogers
@ 2020-06-09 5:36 ` Ian Rogers
2020-06-09 15:37 ` Arnaldo Carvalho de Melo
2020-06-09 15:36 ` [PATCH 1/2] perf parse-events: fix an incompatible pointer Arnaldo Carvalho de Melo
1 sibling, 1 reply; 4+ messages in thread
From: Ian Rogers @ 2020-06-09 5:36 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Mark Rutland, Alexander Shishkin, Jiri Olsa, Namhyung Kim,
Andi Kleen, linux-kernel
Cc: Stephane Eranian, Ian Rogers
Fixes: a26e47162d76 (perf tools: Move ALLOC_LIST into a function)
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/util/parse-events.y | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/parse-events.y b/tools/perf/util/parse-events.y
index d4e076c9c2ab..acef87d9af58 100644
--- a/tools/perf/util/parse-events.y
+++ b/tools/perf/util/parse-events.y
@@ -26,7 +26,7 @@ do { \
YYABORT; \
} while (0)
-static struct list_head* alloc_list()
+static struct list_head* alloc_list(void)
{
struct list_head *list;
--
2.27.0.278.ge193c7cf3a9-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 2/2] perf parse-events: fix an old style declaration
2020-06-09 5:36 ` [PATCH 2/2] perf parse-events: fix an old style declaration Ian Rogers
@ 2020-06-09 15:37 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 4+ messages in thread
From: Arnaldo Carvalho de Melo @ 2020-06-09 15:37 UTC (permalink / raw)
To: Ian Rogers
Cc: Peter Zijlstra, Ingo Molnar, Mark Rutland, Alexander Shishkin,
Jiri Olsa, Namhyung Kim, Andi Kleen, linux-kernel,
Stephane Eranian
Em Mon, Jun 08, 2020 at 10:36:10PM -0700, Ian Rogers escreveu:
> Fixes: a26e47162d76 (perf tools: Move ALLOC_LIST into a function)
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
> tools/perf/util/parse-events.y | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/parse-events.y b/tools/perf/util/parse-events.y
> index d4e076c9c2ab..acef87d9af58 100644
> --- a/tools/perf/util/parse-events.y
> +++ b/tools/perf/util/parse-events.y
> @@ -26,7 +26,7 @@ do { \
> YYABORT; \
> } while (0)
>
> -static struct list_head* alloc_list()
> +static struct list_head* alloc_list(void)
> {
> struct list_head *list;
Thanks, applied.
- Arnaldo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] perf parse-events: fix an incompatible pointer
2020-06-09 5:36 [PATCH 1/2] perf parse-events: fix an incompatible pointer Ian Rogers
2020-06-09 5:36 ` [PATCH 2/2] perf parse-events: fix an old style declaration Ian Rogers
@ 2020-06-09 15:36 ` Arnaldo Carvalho de Melo
1 sibling, 0 replies; 4+ messages in thread
From: Arnaldo Carvalho de Melo @ 2020-06-09 15:36 UTC (permalink / raw)
To: Ian Rogers
Cc: Peter Zijlstra, Ingo Molnar, Mark Rutland, Alexander Shishkin,
Jiri Olsa, Namhyung Kim, Andi Kleen, linux-kernel,
Stephane Eranian
Em Mon, Jun 08, 2020 at 10:36:09PM -0700, Ian Rogers escreveu:
> Arrays are pointer types and don't need their address taking.
> Fixes: 8255718f4bed (perf pmu: Expand PMU events by prefix match)
Thanks, applied.
- Arnaldo
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
> tools/perf/util/parse-events.y | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/parse-events.y b/tools/perf/util/parse-events.y
> index c4ca932d092d..d4e076c9c2ab 100644
> --- a/tools/perf/util/parse-events.y
> +++ b/tools/perf/util/parse-events.y
> @@ -349,7 +349,7 @@ PE_PMU_EVENT_PRE '-' PE_PMU_EVENT_SUF sep_dc
> struct list_head *list;
> char pmu_name[128];
>
> - snprintf(&pmu_name, 128, "%s-%s", $1, $3);
> + snprintf(pmu_name, sizeof(pmu_name), "%s-%s", $1, $3);
> free($1);
> free($3);
> if (parse_events_multi_pmu_add(_parse_state, pmu_name, &list) < 0)
> --
> 2.27.0.278.ge193c7cf3a9-goog
>
--
- Arnaldo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-06-09 15:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-09 5:36 [PATCH 1/2] perf parse-events: fix an incompatible pointer Ian Rogers
2020-06-09 5:36 ` [PATCH 2/2] perf parse-events: fix an old style declaration Ian Rogers
2020-06-09 15:37 ` Arnaldo Carvalho de Melo
2020-06-09 15:36 ` [PATCH 1/2] perf parse-events: fix an incompatible pointer Arnaldo Carvalho de Melo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox