Re: [PATCH 4.19 11/25] iio: vcnl4000: Fix i2c swapped word reading.

Pavel Machek
2020-06-15T13:30:27Z

[-- Attachment #1: Type: text/plain, Size: 801 bytes --]

Hi!

> From: Mathieu Othacehe <m.othacehe@gmail.com>
>
> commit 18dfb5326370991c81a6d1ed6d1aeee055cb8c05 upstream.
>
> The bytes returned by the i2c reading need to be swapped
> unconditionally. Otherwise, on be16 platforms, an incorrect value will be
> returned.
>
> Taking the slow path via next merge window as its been around a while
> and we have a patch set dependent on this which would be held up.

Is there some explanation how this is correct Somewhere? I assume i2c
hardware has fixed endianity (not depending on CPU), so unconditional
swapping will cause problems either on le or on be machines...?

Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]