Re: [PATCH] libbpf: Define __WORDSIZE if not available

Daniel Borkmann
2020-06-09T23:22:08Z

On 6/9/20 11:16 PM, Arnaldo Carvalho de Melo wrote:
> Em Tue, Jun 09, 2020 at 10:37:48PM +0200, Daniel Borkmann escreveu:
>> Hey Arnaldo,
>>
>> On 6/9/20 5:34 PM, Arnaldo Carvalho de Melo wrote:
>>> Some systems, such as Android, don't have a define for __WORDSIZE, do it
>>> in terms of __SIZEOF_LONG__, as done in perf since 2012:
>>>
>>> http://git.kernel.org/torvalds/c/3f34f6c0233ae055b5
>>>
>>> For reference: https://gcc.gnu.org/onlinedocs/cpp/Common-Predefined-Macros.html
>>>
>>> I build tested it here and Andrii did some Travis CI build tests too.
>>>
>>> Acked-by: Andrii Nakryiko <andriin@fb.com>
>>> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>>
>> Diff missing?
>
> Oh well, sorry about that, EBADCOFFEE or something:
>
> From: Arnaldo Carvalho de Melo <acme@kernel.org>
>
> Some systems, such as Android, don't have a define for __WORDSIZE, do it
> in terms of __SIZEOF_LONG__, as done in perf since 2012:
>
> http://git.kernel.org/torvalds/c/3f34f6c0233ae055b5
>
> For reference: https://gcc.gnu.org/onlinedocs/cpp/Common-Predefined-Macros.html
>
> I build tested it here and Andrii did some Travis CI build tests too.
>
> Acked-by: Andrii Nakryiko <andriin@fb.com>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
[...]

Applied, thanks!