From: Quentin Perret <qperret@google.com>
To: Douglas Anderson <dianders@chromium.org>
Cc: Benson Leung <bleung@chromium.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
hsinyi@chromium.org, joelaf@google.com, peterz@infradead.org,
drinkcat@chromium.org, gwendal@chromium.org,
ctheegal@codeaurora.org, Guenter Roeck <groeck@chromium.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cros_ec_spi: Even though we're RT priority, don't bump cpu freq
Date: Thu, 11 Jun 2020 12:03:01 +0100 [thread overview]
Message-ID: <20200611110301.GA132747@google.com> (raw)
In-Reply-To: <20200610151818.1.I666ecd9c6f3c6405bd75831a21001b8109b6438c@changeid>
Hi Doug,
On Wednesday 10 Jun 2020 at 15:18:43 (-0700), Douglas Anderson wrote:
> The cros_ec_spi driver is realtime priority so that it doesn't get
> preempted by other taks while it's talking to the EC but overall it
> really doesn't need lots of compute power. Unfortunately, by default,
> the kernel assumes that all realtime tasks should cause the cpufreq to
> jump to max and burn through power to get things done as quickly as
> possible. That's just not the correct behavior for cros_ec_spi.
Is this specific to this driver, or something you would want applied
more globally to all RT tasks in ChromeOS (which is what we'd like to
have in Android for instance)?
IOW, how do you feel about 20200511154053.7822-1-qais.yousef@arm.com ?
Otherwise, the patch looks good to me.
Thanks,
Quentin
next prev parent reply other threads:[~2020-06-11 11:03 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-10 22:18 [PATCH] cros_ec_spi: Even though we're RT priority, don't bump cpu freq Douglas Anderson
2020-06-11 11:03 ` Quentin Perret [this message]
2020-06-11 17:48 ` Doug Anderson
2020-06-12 9:24 ` Quentin Perret
2020-06-12 12:34 ` Qais Yousef
2020-06-12 13:47 ` Quentin Perret
2020-06-12 14:00 ` Qais Yousef
2020-06-18 21:31 ` Doug Anderson
2020-06-19 15:31 ` Qais Yousef
2020-06-22 18:19 ` Doug Anderson
2020-06-23 15:56 ` Qais Yousef
2020-06-12 12:52 ` Qais Yousef
2020-06-18 21:18 ` Doug Anderson
2020-06-19 15:38 ` Qais Yousef
2020-06-22 18:21 ` Doug Anderson
2020-06-23 16:40 ` Qais Yousef
2020-06-24 15:49 ` Joel Fernandes
2020-06-24 16:55 ` Qais Yousef
2020-06-24 17:35 ` Joel Fernandes
2020-06-24 17:52 ` Qais Yousef
2020-06-24 17:55 ` Joel Fernandes
2020-06-24 18:29 ` Doug Anderson
2020-06-25 14:20 ` Qais Yousef
2020-06-24 16:01 ` Peter Zijlstra
2020-06-24 17:14 ` Qais Yousef
2020-06-24 15:56 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200611110301.GA132747@google.com \
--to=qperret@google.com \
--cc=bleung@chromium.org \
--cc=ctheegal@codeaurora.org \
--cc=dianders@chromium.org \
--cc=drinkcat@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=gwendal@chromium.org \
--cc=hsinyi@chromium.org \
--cc=joelaf@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox