From: Leon Romanovsky <leon@kernel.org>
To: Joe Perches <joe@perches.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andy Whitcroft <apw@canonical.com>,
Matteo Croce <mcroce@redhat.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] checkpatch.pl: perform commit ID check from external to git folder
Date: Thu, 11 Jun 2020 23:08:07 +0300 [thread overview]
Message-ID: <20200611200807.GC1933365@unreal> (raw)
In-Reply-To: <fcd6d2c34c082ee3dd21a1c3bfd558306e566261.camel@perches.com>
On Thu, Jun 11, 2020 at 11:22:41AM -0700, Joe Perches wrote:
> On Thu, 2020-06-11 at 15:59 +0300, Leon Romanovsky wrote:
> > From: Leon Romanovsky <leonro@mellanox.com>
> >
> > The execution of scripts/checkpatch.pl in folder outside of git produces
> > complains about invalid commit ID, despite having valid one.
>
> There is already a slightly different test for this in -next
> It also uses a environment test for GIT_DIR.
If you are referring to this commit
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/scripts/checkpatch.pl?h=next-20200611&id=5bff933936a76a839e3c7f47f193cbf0d9904543
It didn't work for me, because I'm not setting GIT_DIR environment and
use "--root" switch from checkpatch.pl.
>
> Try that one.
It doesn't make too much sense to have two options to configure git
directory, one is GIT_DIR and another --root.
Thanks
>
>
prev parent reply other threads:[~2020-06-11 20:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 12:59 [PATCH] checkpatch.pl: perform commit ID check from external to git folder Leon Romanovsky
2020-06-11 18:22 ` Joe Perches
2020-06-11 20:08 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200611200807.GC1933365@unreal \
--to=leon@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mcroce@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox