Re: [Freedreno] [PATCH v6 0/5] Add support for DisplayPort driver on

Jeffrey Hugo
2020-06-15T23:05:14Z

On Mon, Jun 15, 2020 at 4:51 PM <tanmay@codeaurora.org> wrote:
>
> On 2020-06-12 16:26, Stephen Boyd wrote:
>
> Thanks for reviews Stephen.
>
> > Quoting Tanmay Shah (2020-06-11 18:50:25)
> >> These patches add support for Display-Port driver on SnapDragon
> >> hardware. It adds
> >> DP driver and DP PLL driver files along with the needed device-tree
> >> bindings.
> >>
> >> The block diagram of DP driver is shown below:
> >>
> >>
> >> +-------------+
> >> |DRM FRAMEWORK|
> >> +------+------+
> >> |
> >> +----v----+
> >> | DP DRM |
> >> +----+----+
> >> |
> >> +----v----+
> >> +------------+| DP +----------++------+
> >> + +---+| DISPLAY |+---+ | |
> >> | + +-+-----+-+ | | |
> >> | | | | | | |
> >> | | | | | | |
> >> | | | | | | |
> >> v v v v v v v
> >> +------+ +------+ +---+ +----+ +----+ +---+ +-----+
> >> | DP | | DP | |DP | | DP | | DP | |DP | | DP |
> >> |PARSER| | HPD | |AUX| |LINK| |CTRL| |PHY| |POWER|
> >> +--+---+ +---+--+ +---+ +----+ +--+-+ +-+-+ +-----+
> >> | | |
> >> +--v---+ +v-----v+
> >> |DEVICE| | DP |
> >> | TREE | |CATALOG|
> >> +------+ +---+---+
> >> |
> >> +---v----+
> >> |CTRL/PHY|
> >> | HW |
> >> +--------+
> >>
> >
> > I've never seen a block diagram for a driver before...
> >
> It is here for v5. https://patchwork.freedesktop.org/series/74312/

I think Stephen is nitpicking your wording, and you seem to not be
understanding his comment. I'm sorry if I am mistaken.

The "DP driver" would seem to refer to the linux software driver you
are proposing patches for, however this diagram looks like a hardware
diagram of the various hardware blocks that the Linux driver code (the
"DP driver") is expected to interact with. I believe you should
re-word "The block diagram of DP driver is shown below:" to be more
specific of what you are describing with your figure. IE your words
say this is a block diagram of the software, when it looks like it is
a block diagram of the hardware.