Re: [Freedreno] [PATCH v6 0/5] Add support for DisplayPort driver on

tanmay
2020-06-15T23:37:11Z

On 2020-06-15 16:04, Jeffrey Hugo wrote:
> On Mon, Jun 15, 2020 at 4:51 PM <tanmay@codeaurora.org> wrote:
>>
>> On 2020-06-12 16:26, Stephen Boyd wrote:
>>
>> Thanks for reviews Stephen.
>>
>> > Quoting Tanmay Shah (2020-06-11 18:50:25)
>> >> These patches add support for Display-Port driver on SnapDragon
>> >> hardware. It adds
>> >> DP driver and DP PLL driver files along with the needed device-tree
>> >> bindings.
>> >>
>> >> The block diagram of DP driver is shown below:
>> >>
>> >>
>> >> +-------------+
>> >> |DRM FRAMEWORK|
>> >> +------+------+
>> >> |
>> >> +----v----+
>> >> | DP DRM |
>> >> +----+----+
>> >> |
>> >> +----v----+
>> >> +------------+| DP +----------++------+
>> >> + +---+| DISPLAY |+---+ | |
>> >> | + +-+-----+-+ | | |
>> >> | | | | | | |
>> >> | | | | | | |
>> >> | | | | | | |
>> >> v v v v v v v
>> >> +------+ +------+ +---+ +----+ +----+ +---+ +-----+
>> >> | DP | | DP | |DP | | DP | | DP | |DP | | DP |
>> >> |PARSER| | HPD | |AUX| |LINK| |CTRL| |PHY| |POWER|
>> >> +--+---+ +---+--+ +---+ +----+ +--+-+ +-+-+ +-----+
>> >> | | |
>> >> +--v---+ +v-----v+
>> >> |DEVICE| | DP |
>> >> | TREE | |CATALOG|
>> >> +------+ +---+---+
>> >> |
>> >> +---v----+
>> >> |CTRL/PHY|
>> >> | HW |
>> >> +--------+
>> >>
>> >
>> > I've never seen a block diagram for a driver before...
>> >
>> It is here for v5. https://patchwork.freedesktop.org/series/74312/
>
> I think Stephen is nitpicking your wording, and you seem to not be
> understanding his comment. I'm sorry if I am mistaken.
>
> The "DP driver" would seem to refer to the linux software driver you
> are proposing patches for, however this diagram looks like a hardware
> diagram of the various hardware blocks that the Linux driver code (the
> "DP driver") is expected to interact with. I believe you should
> re-word "The block diagram of DP driver is shown below:" to be more
> specific of what you are describing with your figure. IE your words
> say this is a block diagram of the software, when it looks like it is
> a block diagram of the hardware.

Thanks for reviews.

I am not sure what Stephen meant, but this diagram was available before.

Just for clarification this is not hardware diagram at all.
This is modeling of DP driver for msm.
Each box name above except "DRM framework", is file name in driver i.e.
software module.
Each line and arrow shows how modules interact with each other.

For example, "DP PARSER" Box is pointing towards "DEVICE TREE" Box, that
means
dp_parser.c file contains functions which are parsing device tree
properties and so on...