[PATCH 0/2] gpiolib: cdev: fixes for split from gpiolib.c

[PATCH 0/2] gpiolib: cdev: fixes for split from gpiolib.c

[Kent Gibson]

A couple of minor fixes for the recent split from gpiolib.c:
The first fixes a couple of W=1 build warnings by including the module's
own header.
The second fixes the file comment.  This was in v3 of the split patch,
but v2 got merged...

Kent Gibson (2):
  gpiolib: cdev: fix -Wmissing-prototypes warnings
  gpiolib: cdev: fix file comment

 drivers/gpio/gpiolib-cdev.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)


base-commit: f6d984418ffde19322fd149105200224ac2bc089
-- 
2.27.0

[PATCH 1/2] gpiolib: cdev: fix -Wmissing-prototypes warnings

[Kent Gibson]

Fix -Wmissing-prototypes warnings by including module's header.

Fixes: f6d984418ffd (gpiolib: split character device into gpiolib-cdev)
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Kent Gibson <warthog618@gmail.com>
---
 drivers/gpio/gpiolib-cdev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpio/gpiolib-cdev.c b/drivers/gpio/gpiolib-cdev.c
index 971470bdc9c9..58011ba88a1d 100644
--- a/drivers/gpio/gpiolib-cdev.c
+++ b/drivers/gpio/gpiolib-cdev.c
@@ -23,6 +23,7 @@
 
 
 #include "gpiolib.h"
+#include "gpiolib-cdev.h"
 
 /* Implementation infrastructure for GPIO interfaces.
  *
-- 
2.27.0

Re: [PATCH 1/2] gpiolib: cdev: fix -Wmissing-prototypes warnings

[Bartosz Golaszewski]

pt., 12 cze 2020 o 06:51 Kent Gibson <warthog618@gmail.com> napisał(a):
>
> Fix -Wmissing-prototypes warnings by including module's header.
>
> Fixes: f6d984418ffd (gpiolib: split character device into gpiolib-cdev)
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Kent Gibson <warthog618@gmail.com>
> ---
>  drivers/gpio/gpiolib-cdev.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/gpiolib-cdev.c b/drivers/gpio/gpiolib-cdev.c
> index 971470bdc9c9..58011ba88a1d 100644
> --- a/drivers/gpio/gpiolib-cdev.c
> +++ b/drivers/gpio/gpiolib-cdev.c
> @@ -23,6 +23,7 @@
>
>
>  #include "gpiolib.h"
> +#include "gpiolib-cdev.h"
>
>  /* Implementation infrastructure for GPIO interfaces.
>   *
> --
> 2.27.0
>

Reviewed-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>

[PATCH 2/2] gpiolib: cdev: fix file comment

[Kent Gibson]

Replace file comment carried over from gpiolib.c with one more
appropriate for gpiolib-cdev.c.

Signed-off-by: Kent Gibson <warthog618@gmail.com>
---
 drivers/gpio/gpiolib-cdev.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/gpio/gpiolib-cdev.c b/drivers/gpio/gpiolib-cdev.c
index 58011ba88a1d..17d5541d76a0 100644
--- a/drivers/gpio/gpiolib-cdev.c
+++ b/drivers/gpio/gpiolib-cdev.c
@@ -25,11 +25,10 @@
 #include "gpiolib.h"
 #include "gpiolib-cdev.h"
 
-/* Implementation infrastructure for GPIO interfaces.
+/* Character device interface to GPIO.
  *
- * The GPIO programming interface allows for inlining speed-critical
- * get/set operations for common cases, so that access to SOC-integrated
- * GPIOs can sometimes cost only an instruction or two per bit.
+ * The GPIO character device, /dev/gpiochipN, provides userspace an
+ * interface to gpiolib GPIOs via ioctl()s.
  */
 
 /*
-- 
2.27.0

Re: [PATCH 2/2] gpiolib: cdev: fix file comment

[Bartosz Golaszewski]

pt., 12 cze 2020 o 06:51 Kent Gibson <warthog618@gmail.com> napisał(a):
>
> Replace file comment carried over from gpiolib.c with one more
> appropriate for gpiolib-cdev.c.
>
> Signed-off-by: Kent Gibson <warthog618@gmail.com>
> ---
>  drivers/gpio/gpiolib-cdev.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpio/gpiolib-cdev.c b/drivers/gpio/gpiolib-cdev.c
> index 58011ba88a1d..17d5541d76a0 100644
> --- a/drivers/gpio/gpiolib-cdev.c
> +++ b/drivers/gpio/gpiolib-cdev.c
> @@ -25,11 +25,10 @@
>  #include "gpiolib.h"
>  #include "gpiolib-cdev.h"
>
> -/* Implementation infrastructure for GPIO interfaces.
> +/* Character device interface to GPIO.
>   *
> - * The GPIO programming interface allows for inlining speed-critical
> - * get/set operations for common cases, so that access to SOC-integrated
> - * GPIOs can sometimes cost only an instruction or two per bit.
> + * The GPIO character device, /dev/gpiochipN, provides userspace an
> + * interface to gpiolib GPIOs via ioctl()s.
>   */
>
>  /*
> --
> 2.27.0
>

Reviewed-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>