public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Kaitao Cheng <pilgrimtao@gmail.com>
To: adobriyan@gmail.com, Markus.Elfring@web.de
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	songmuchun@bytedance.com, kernel-janitors@vger.kernel.org,
	Kaitao Cheng <pilgrimtao@gmail.com>
Subject: [PATCH v2] proc/fd: Remove unnecessary {files, f_flags, file} initialization in seq_show()
Date: Sat, 13 Jun 2020 00:09:46 +0800	[thread overview]
Message-ID: <20200612160946.21187-1-pilgrimtao@gmail.com> (raw)

'files' will be immediately reassigned. 'f_flags' and 'file' will be
overwritten in the if{} or seq_show() directly exits with an error.
so we don't need to consume CPU resources to initialize them.

Signed-off-by: Kaitao Cheng <pilgrimtao@gmail.com>
---

v2 ChangeLog:
  1. Fix some commit message
  2. Remove unnecessary f_flags initialization

 fs/proc/fd.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/fs/proc/fd.c b/fs/proc/fd.c
index 81882a13212d..d3854b76e95e 100644
--- a/fs/proc/fd.c
+++ b/fs/proc/fd.c
@@ -19,9 +19,9 @@
 
 static int seq_show(struct seq_file *m, void *v)
 {
-	struct files_struct *files = NULL;
-	int f_flags = 0, ret = -ENOENT;
-	struct file *file = NULL;
+	struct files_struct *files;
+	int f_flags, ret = -ENOENT;
+	struct file *file;
 	struct task_struct *task;
 
 	task = get_proc_task(m->private);
-- 
2.20.1


             reply	other threads:[~2020-06-12 16:10 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-12 16:09 Kaitao Cheng [this message]
2020-06-12 16:45 ` [PATCH v2] proc/fd: Remove unnecessary variable initialisations in seq_show() Markus Elfring
2020-06-12 17:00   ` Matthew Wilcox
2020-06-12 17:03     ` Markus Elfring
2020-06-12 17:03     ` Markus Elfring
2020-06-12 17:04       ` Matthew Wilcox
2020-06-12 18:22         ` [v2] " Markus Elfring
2020-06-12 18:28           ` Matthew Wilcox
2020-06-12 18:43             ` Markus Elfring
2020-06-12 18:47               ` Matthew Wilcox
2020-06-12 19:00                 ` Markus Elfring
2020-06-12 19:02                   ` Matthew Wilcox
2020-06-12 19:49                   ` Al Viro
2020-06-12 19:00                 ` Markus Elfring
2020-06-14  7:12   ` [PATCH v2] " Greg KH
2020-07-07  7:23 ` [PATCH v2] proc/fd: Adjust " Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200612160946.21187-1-pilgrimtao@gmail.com \
    --to=pilgrimtao@gmail.com \
    --cc=Markus.Elfring@web.de \
    --cc=adobriyan@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=songmuchun@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox