Re: [PATCH] rocker: Fix error handling in dma_rings_init()

Re: [PATCH] rocker: Fix error handling in dma_rings_init()

[Markus Elfring]

> … The patch fixes the
> order consistent with cleanup in rocker_dma_rings_fini().

I suggest to choose another imperative wording for your change description.
Will the tag “Fixes” become helpful for the commit message?

Regards,
Markus

Re: [PATCH] rocker: Fix error handling in dma_rings_init()

[Greg KH]

On Sat, Jun 13, 2020 at 08:14:13AM +0200, Markus Elfring wrote:
> > … The patch fixes the
> > order consistent with cleanup in rocker_dma_rings_fini().
> 
> I suggest to choose another imperative wording for your change description.
> Will the tag “Fixes” become helpful for the commit message?
> 
> Regards,
> Markus

Hi,

This is the semi-friendly patch-bot of Greg Kroah-Hartman.

Markus, you seem to have sent a nonsensical or otherwise pointless
review comment to a patch submission on a Linux kernel developer mailing
list.  I strongly suggest that you not do this anymore.  Please do not
bother developers who are actively working to produce patches and
features with comments that, in the end, are a waste of time.

Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all.  The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback.  Please feel free to also ignore emails
from them.

thanks,

greg k-h's patch email bot