From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F03BEC433DF for ; Sun, 14 Jun 2020 07:14:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BF0D920714 for ; Sun, 14 Jun 2020 07:14:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592118887; bh=zbXjGnPMX45JTqiR/mVy9+/B30zxTdS7yJsyaBGVEpM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=FbcLwJikXgvK28YUH5kAbzPYAX181uB6t+OzVw+NjQZ96QrglsPwkJYuGPKaqkb1c tcETCtrZMDy8PS3Go4nsQoOR2IyoQvWt9Cdim8hATFe9/cGa7IoypALWQh/fSpfW1z Efr9YyCfBJu0BLLr7Gkdqqj9DX/3EwptgwKx4EIk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726891AbgFNHOq (ORCPT ); Sun, 14 Jun 2020 03:14:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:33886 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725949AbgFNHOp (ORCPT ); Sun, 14 Jun 2020 03:14:45 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B122F20714; Sun, 14 Jun 2020 07:14:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592118885; bh=zbXjGnPMX45JTqiR/mVy9+/B30zxTdS7yJsyaBGVEpM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=W3O5JXHe6DexW5W8Wge6ykuSUJFdZCx2nwpHNc6Wg/SnV8nFeIZss+ts3PyIrpjnK 99MKA+lUhztVHk4QlgKLCbcsrPPoI3bzsU30JfpWe9pcCR4nPjFVDcg1c5eDAIt+W6 S/NUlfPlgioxjUPpvamcw9wncg5IE9zPw9sICnuU= Date: Sun, 14 Jun 2020 09:14:42 +0200 From: Greg KH To: Markus Elfring Cc: Aditya Pakki , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" , Jakub Kicinski , Jiri Pirko , Kangjie Lu , Qiushi Wu Subject: Re: [PATCH] rocker: Fix error handling in dma_rings_init() Message-ID: <20200614071442.GD2629255@kroah.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jun 13, 2020 at 08:14:13AM +0200, Markus Elfring wrote: > > … The patch fixes the > > order consistent with cleanup in rocker_dma_rings_fini(). > > I suggest to choose another imperative wording for your change description. > Will the tag “Fixes” become helpful for the commit message? > > Regards, > Markus Hi, This is the semi-friendly patch-bot of Greg Kroah-Hartman. Markus, you seem to have sent a nonsensical or otherwise pointless review comment to a patch submission on a Linux kernel developer mailing list. I strongly suggest that you not do this anymore. Please do not bother developers who are actively working to produce patches and features with comments that, in the end, are a waste of time. Patch submitter, please ignore Markus's suggestion; you do not need to follow it at all. The person/bot/AI that sent it is being ignored by almost all Linux kernel maintainers for having a persistent pattern of behavior of producing distracting and pointless commentary, and inability to adapt to feedback. Please feel free to also ignore emails from them. thanks, greg k-h's patch email bot