* Re: [PATCH] rocker: Fix error handling in dma_rings_init()
@ 2020-06-13 6:14 Markus Elfring
2020-06-14 7:14 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Markus Elfring @ 2020-06-13 6:14 UTC (permalink / raw)
To: Aditya Pakki, netdev
Cc: linux-kernel, David S. Miller, Jakub Kicinski, Jiri Pirko,
Kangjie Lu, Qiushi Wu
> … The patch fixes the
> order consistent with cleanup in rocker_dma_rings_fini().
I suggest to choose another imperative wording for your change description.
Will the tag “Fixes” become helpful for the commit message?
Regards,
Markus
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] rocker: Fix error handling in dma_rings_init()
2020-06-13 6:14 [PATCH] rocker: Fix error handling in dma_rings_init() Markus Elfring
@ 2020-06-14 7:14 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2020-06-14 7:14 UTC (permalink / raw)
To: Markus Elfring
Cc: Aditya Pakki, netdev, linux-kernel, David S. Miller,
Jakub Kicinski, Jiri Pirko, Kangjie Lu, Qiushi Wu
On Sat, Jun 13, 2020 at 08:14:13AM +0200, Markus Elfring wrote:
> > … The patch fixes the
> > order consistent with cleanup in rocker_dma_rings_fini().
>
> I suggest to choose another imperative wording for your change description.
> Will the tag “Fixes” become helpful for the commit message?
>
> Regards,
> Markus
Hi,
This is the semi-friendly patch-bot of Greg Kroah-Hartman.
Markus, you seem to have sent a nonsensical or otherwise pointless
review comment to a patch submission on a Linux kernel developer mailing
list. I strongly suggest that you not do this anymore. Please do not
bother developers who are actively working to produce patches and
features with comments that, in the end, are a waste of time.
Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all. The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback. Please feel free to also ignore emails
from them.
thanks,
greg k-h's patch email bot
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-14 7:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-13 6:14 [PATCH] rocker: Fix error handling in dma_rings_init() Markus Elfring
2020-06-14 7:14 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox