From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D876C433DF for ; Sun, 14 Jun 2020 11:18:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E786D20714 for ; Sun, 14 Jun 2020 11:18:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592133529; bh=cxDB1FPumFu9taynLLB3wnJOdrr5+Q2VR1Lx3+78SkI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=dS1d+H0m9stqiRm5RhJEnTFyeRN/zsx4GRUqhMR4SRc9wWQtkv6GrIaqEi6K11r7M 0o8fJHT+k38egVu5LOWSmXs4GkTb6KlBmK4+4GbZYWjbJ2keNfuMKthrWpQuyeINvE mBZ+EP5soYIDEAPd5JBT2wQTZISKNZW+nq2o7vjw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727080AbgFNLSs (ORCPT ); Sun, 14 Jun 2020 07:18:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:43808 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726630AbgFNLSr (ORCPT ); Sun, 14 Jun 2020 07:18:47 -0400 Received: from localhost (p5486c990.dip0.t-ipconnect.de [84.134.201.144]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 409E22068E; Sun, 14 Jun 2020 11:18:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592133526; bh=cxDB1FPumFu9taynLLB3wnJOdrr5+Q2VR1Lx3+78SkI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fd3cF66raaUz75ozMNM0fhwFlDNkLm798v31XglLCIAT5UccXlB+LzcHx/CB7sQyy X1F46mLkaBmx5Apb789Hv80eNHn9Ob5T2mOX1yzEHi+SwhvM4Li7YbRcf9hJ9IRQHp uGlH26D6WVEdHZ8XmCAN9JU8TCcokz5yk4jw8F1I= Date: Sun, 14 Jun 2020 13:18:39 +0200 From: Wolfram Sang To: Vladimir Oltean Cc: Krzysztof Kozlowski , Mark Brown , Vladimir Oltean , linux-spi , lkml , Pengutronix Kernel Team , Marc Kleine-Budde , stable@vger.kernel.org Subject: Re: [PATCH 2/2] spi: spi-fsl-dspi: Initialize completion before possible interrupt Message-ID: <20200614111839.GA1883@ninjato> References: <1592132154-20175-1-git-send-email-krzk@kernel.org> <1592132154-20175-2-git-send-email-krzk@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="1yeeQ81UyVL57Vl7" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --1yeeQ81UyVL57Vl7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > > If interrupt fires early, the dspi_interrupt() could complete > > (dspi->xfer_done) before its initialization happens. > > > > Fixes: 4f5ee75ea171 ("spi: spi-fsl-dspi: Replace interruptible wait que= ue with a simple completion") > > Cc: > > Signed-off-by: Krzysztof Kozlowski > > --- >=20 > Why would an interrupt fire before spi_register_controller, therefore > before dspi_transfer_one_message could get called? I don't know this HW, but the generic answer usually is: Bootloader used SPI and didn't clean up properly. --1yeeQ81UyVL57Vl7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAl7mB4sACgkQFA3kzBSg KbZD0A//bgaXCsITkWj3QldSdnswEWGMLXHbOZ/hiDQDQhdalBXQfKMBPRoVxp0+ IS/HwMRd/pzggXGJt7tv6LpmZ+eXx1ARmKxPQZBo/+RDF2qLAxKetkU/kX+MDw5K wYXFv7bizFqTwTN6uMDfI44EraCHxTqtgQm9wswDCcDXG+WWCPJ4skdU9h+x/HdL mQ5XFfFxEGIetUKsKv2AXxNH9Q06+KF4wsXBSL4E3jQjoaahEj2WNyt+FF21/4X0 gzhWjxa82acwzHHDXyLhyO9MAJOnwKQxfhsWsxsbHKVWLBLBPtNoXac7M4pLPTqK DFREw95DQyb/IAL8eOfBokVlxdSrzQo0IrJPUtmfWN3R3ybvNNUePWvJ6udeTHyL Wr+LqmEF0jv7+GvhG4orKqInZlaA23PdEZIPrmBaF3vbdiS6RxDTvn13r7uqGXYD 3GL8lkWzl2MEn69zuklAPAKqyb5a7QzPQkzOG9I1grXRN5ErEU6z06F+Lvngef83 VqqvQgQTXL73xsvoXysEkOWoLVp4RfSRi6271H5KO0PTGSs6E8W3quNEEAaKlQsD jGlkbJZpVtvbgs0+QS4glIt/zCawe+M81vk1lyq0TRrGObOzin8AKVVngMuk6rJ2 gebkH6HZC8PQEc/8fxEmnUBHgrTtw5nP8qvsm3d9YkME0eG6Vbs= =76dA -----END PGP SIGNATURE----- --1yeeQ81UyVL57Vl7--