From: Guenter Roeck <linux@roeck-us.net>
To: Wang Qing <wangqing@vivo.com>
Cc: Jean Delvare <jdelvare@suse.com>,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/hwmon/nct6683: Use kobj_to_dev() instead
Date: Sun, 14 Jun 2020 14:44:49 -0700 [thread overview]
Message-ID: <20200614214449.GA102702@roeck-us.net> (raw)
In-Reply-To: <1592035604-22336-1-git-send-email-wangqing@vivo.com>
On Sat, Jun 13, 2020 at 04:06:44PM +0800, Wang Qing wrote:
> Use kobj_to_dev() instead of container_of()
>
> Signed-off-by: Wang Qing <wangqing@vivo.com>
Applied. For future patches, I would suggest to look up subject labels
used in affected subsystems.
Thanks,
Guenter
> ---
> drivers/hwmon/nct6683.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
> mode change 100644 => 100755 drivers/hwmon/nct6683.c
>
> diff --git a/drivers/hwmon/nct6683.c b/drivers/hwmon/nct6683.c
> index c022915..2d29914
> --- a/drivers/hwmon/nct6683.c
> +++ b/drivers/hwmon/nct6683.c
> @@ -674,7 +674,7 @@ show_in_reg(struct device *dev, struct device_attribute *attr, char *buf)
> static umode_t nct6683_in_is_visible(struct kobject *kobj,
> struct attribute *attr, int index)
> {
> - struct device *dev = container_of(kobj, struct device, kobj);
> + struct device *dev = kobj_to_dev(kobj);
> struct nct6683_data *data = dev_get_drvdata(dev);
> int nr = index % 4; /* attribute */
>
> @@ -739,7 +739,7 @@ show_fan_pulses(struct device *dev, struct device_attribute *attr, char *buf)
> static umode_t nct6683_fan_is_visible(struct kobject *kobj,
> struct attribute *attr, int index)
> {
> - struct device *dev = container_of(kobj, struct device, kobj);
> + struct device *dev = kobj_to_dev(kobj);
> struct nct6683_data *data = dev_get_drvdata(dev);
> int fan = index / 3; /* fan index */
> int nr = index % 3; /* attribute index */
> @@ -857,7 +857,7 @@ show_temp_type(struct device *dev, struct device_attribute *attr, char *buf)
> static umode_t nct6683_temp_is_visible(struct kobject *kobj,
> struct attribute *attr, int index)
> {
> - struct device *dev = container_of(kobj, struct device, kobj);
> + struct device *dev = kobj_to_dev(kobj);
> struct nct6683_data *data = dev_get_drvdata(dev);
> int temp = index / 7; /* temp index */
> int nr = index % 7; /* attribute index */
> @@ -944,7 +944,7 @@ SENSOR_TEMPLATE(pwm, "pwm%d", S_IRUGO, show_pwm, store_pwm, 0);
> static umode_t nct6683_pwm_is_visible(struct kobject *kobj,
> struct attribute *attr, int index)
> {
> - struct device *dev = container_of(kobj, struct device, kobj);
> + struct device *dev = kobj_to_dev(kobj);
> struct nct6683_data *data = dev_get_drvdata(dev);
> int pwm = index; /* pwm index */
>
prev parent reply other threads:[~2020-06-14 21:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-13 8:06 [PATCH] drivers/hwmon/nct6683: Use kobj_to_dev() instead Wang Qing
2020-06-14 21:44 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200614214449.GA102702@roeck-us.net \
--to=linux@roeck-us.net \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wangqing@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox