From: Krzysztof Kozlowski <krzk@kernel.org>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: Mark Brown <broonie@kernel.org>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
linux-spi <linux-spi@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Marc Kleine-Budde <mkl@pengutronix.de>,
Wolfram Sang <wsa@kernel.org>,
stable@vger.kernel.org
Subject: Re: [PATCH 2/2] spi: spi-fsl-dspi: Initialize completion before possible interrupt
Date: Mon, 15 Jun 2020 11:30:48 +0200 [thread overview]
Message-ID: <20200615093048.GA26906@kozik-lap> (raw)
In-Reply-To: <CA+h21hoLq59R2p=+f4jZFmd5OSQ3590FeRB+oHBKLKDHq5knRg@mail.gmail.com>
On Mon, Jun 15, 2020 at 12:26:37PM +0300, Vladimir Oltean wrote:
> Let's rephrase it: you think therefore that completion should be
> > initialzed *after* requesting shared interrupts? You think that exactly
> > that order shall be used in the source code?
> >
> > Best regards,
> > Krzysztof
> >
> >
>
> I think that completion should be initialized before it is used, just
> like any other variable. So far you have not proven any code path
> through which it can be used uninitialized, therefore I don't see why
> this should be accepted as a bug fix. Cleanup, cosmetic refactoring,
> design patterns, whatever, sure.
Sure, let it call then cleanup, cosmetic refactoring.
Best regards,
Krzysztof
next prev parent reply other threads:[~2020-06-15 9:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-14 10:55 [PATCH 1/2] spi: spi-fsl-dspi: Fix external abort on interrupt in exit paths Krzysztof Kozlowski
2020-06-14 10:55 ` [PATCH 2/2] spi: spi-fsl-dspi: Initialize completion before possible interrupt Krzysztof Kozlowski
2020-06-14 11:14 ` Vladimir Oltean
2020-06-14 11:18 ` Krzysztof Kozlowski
2020-06-14 13:39 ` Vladimir Oltean
2020-06-14 13:43 ` Vladimir Oltean
2020-06-14 15:12 ` Krzysztof Kozlowski
2020-06-14 15:34 ` Vladimir Oltean
2020-06-15 7:08 ` Krzysztof Kozlowski
2020-06-15 9:26 ` Vladimir Oltean
2020-06-15 9:30 ` Krzysztof Kozlowski [this message]
2020-06-14 11:18 ` Wolfram Sang
2020-06-14 15:48 ` [PATCH 1/2] spi: spi-fsl-dspi: Fix external abort on interrupt in exit paths Vladimir Oltean
2020-06-15 7:15 ` Krzysztof Kozlowski
2020-06-15 7:51 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200615093048.GA26906@kozik-lap \
--to=krzk@kernel.org \
--cc=broonie@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=olteanv@gmail.com \
--cc=stable@vger.kernel.org \
--cc=vladimir.oltean@nxp.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox