From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ricardo Ferreira <rikajff@gmail.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
devel@driverdev.osuosl.org,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
linux-kernel@vger.kernel.org,
Nishka Dasgupta <nishkadg.linux@gmail.com>,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH v2] Staging: rtl8712: Addressed checkpatch.pl issues related to macro parameter wrapping in parentheses.
Date: Mon, 15 Jun 2020 14:36:39 +0200 [thread overview]
Message-ID: <20200615123639.GC943330@kroah.com> (raw)
In-Reply-To: <20200614173146.28292-1-rikajff@gmail.com>
On Sun, Jun 14, 2020 at 06:31:46PM +0100, Ricardo Ferreira wrote:
> Attempting to wet my feet in kernel patch submission by submitting a checkstyle
> fix for the rtl8712 driver.
>
> Signed-off-by: Ricardo Ferreira <rikajff@gmail.com>
> ---
What changed from v1?
Always put that below the --- line, so please fix this up and do a v3.
Also, your changelog text is very odd, do you see other commits in the
kernel for these files that say things that way? Please try to follow
how others do things. Also read the documentation for how to make a
good changelog text, that will help out a lot.
thanks,
greg k-h
prev parent reply other threads:[~2020-06-15 12:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-14 17:31 [PATCH v2] Staging: rtl8712: Addressed checkpatch.pl issues related to macro parameter wrapping in parentheses Ricardo Ferreira
2020-06-15 1:42 ` kernel test robot
2020-06-15 12:36 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200615123639.GC943330@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Larry.Finger@lwfinger.net \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=florian.c.schilhabel@googlemail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nishkadg.linux@gmail.com \
--cc=rikajff@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox