Re: [PATCH v3 2/4] spi: bcm63xx-spi: allow building for BMIPS

Florian Fainelli
2020-06-16T17:15:23Z

On 6/16/2020 10:07 AM, Mark Brown wrote:
> On Tue, Jun 16, 2020 at 09:02:21AM +0200, Álvaro Fernández Rojas wrote:
>> bcm63xx-spi controller is present on several BMIPS SoCs (BCM6358, BCM6362,
>> BCM6368 and BCM63268).
>
> Please do not submit new versions of already applied patches, please
> submit incremental updates to the existing code. Modifying existing
> commits creates problems for other users building on top of those
> commits so it's best practice to only change pubished git commits if
> absolutely essential.
>

In Alvaro's defense, you applied the patches despite me requesting that
specific changes be made (use the optional reset control API variant).

Having a FAQ entry about what your expectations as a subsystem
maintainer are (ala netdev-FAQ.rst) could save you time along the way.
--
Florian