From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D9BAC433E0 for ; Tue, 16 Jun 2020 10:37:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 59EB6207BC for ; Tue, 16 Jun 2020 10:37:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592303836; bh=z6LDz9/G5pNcQFXdInSqegrHVHuPT3Kls9SWQAPqUyE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=lK+UE9N1j4/VT/+LJTLUNVAG/btF6aanaQvF/G05PLkE1xP++6MnReK9BrkKWnsg8 O2IaEOj/B3l9+wJXKB1Q4arPsmqhB4EEJ353EKmzvXdA/0wY8tbt5IZeXtDtYLLWLO UcqE4hKO4TKOL8TzH9q7/pI6m1aM6AQmi3RkPOe0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728329AbgFPKhP (ORCPT ); Tue, 16 Jun 2020 06:37:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:55596 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726452AbgFPKhM (ORCPT ); Tue, 16 Jun 2020 06:37:12 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5BFF620734; Tue, 16 Jun 2020 10:37:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592303831; bh=z6LDz9/G5pNcQFXdInSqegrHVHuPT3Kls9SWQAPqUyE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=1ivXZbzIEFoy6gy+3lznnGcBN8Tcq5DHKexhF0Wx44juizRN06sl0AESZb+Ay4joU d9AtCdIMcLYsb1iT1VVMSY7cHVBKXr0EUBsnQm61HbdqQNZipQoUtcqy7h69T5ps7d Qv5BWWrT+7nPW6Ac+78DvZQQ8uUIxlvFxDIf+eIs= Date: Tue, 16 Jun 2020 12:37:06 +0200 From: Greg KH To: "Manali Shukla (manashuk)" Cc: Borislav Petkov , "linux-edac@vger.kernel.org" , "mchehab@kernel.org" , "linux-kernel@vger.kernel.org" , "xe-linux-external(mailer list)" , Aristeu Rozanski Filho , Justin Ernst , Russ Anderson , Tony Luck Subject: Re: [ PATCH stable v4.19] EDAC: Drop per-memory controller buses Message-ID: <20200616103706.GA2653240@kroah.com> References: <20200312052201.49456-1-manashuk@cisco.com> <20200317102249.GC1130294@kroah.com> <5D56C6A7-B076-47BB-9016-7BD54DFE71E7@cisco.com> <20200405180605.GC17324@zn.tnic> <994FAF5C-B773-4B09-8C08-91E22ECDB8A9@cisco.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <994FAF5C-B773-4B09-8C08-91E22ECDB8A9@cisco.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 05, 2020 at 07:26:01PM +0000, Manali Shukla (manashuk) wrote: > > On 05/04/20, 11:36 PM, "Borislav Petkov" wrote: > > > On Sun, Apr 05, 2020 at 06:01:21PM +0000, Manali Shukla (manashuk) wrote: > >> With this patch , we are removing per-MC bus, this removes dependency on value of max number of controllers (EDAC_MAX_MCS) which is hardcoded to 2 * MAX_NUMNODES in all stable versions of kernel. > >> On two nodes system MAX_NUMNODES value is ‘1’ , so value of max number of memory controller becomes ‘2’, this patch fixes this issue when there are only 2 nodes on the system and number of memory controllers are more than ‘2' > > > You basically repeated what you had written already. > > > But what is this fixing? Some platform of yours or what? Why does it > > need to go to stable? > > Certain MIPS platform can have 2 nodes and number of memory controllers can be more than '2' . > > for above condition, if > #define EDAC_MAX_MCS 2 * MAX_NUMNODES, > it fails in this function edac_mc_add_mc_with_groups > in below condition > if (mci->mc_idx >= EDAC_MAX_MCS) { > pr_warn_once("Too many memory controllers: %d\n", mci->mc_idx); > return -ENODEV; > } > That is why this fix is needed. What fix? I see no patch in this email, nor do I see a git commit id anywhere :( Totally confused, greg k-h