From: Steven Rostedt <rostedt@goodmis.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Lichao Liu <liulichao@loongson.cn>,
mingo@redhat.com, juri.lelli@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
bsegall@google.com, mgorman@suse.de,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched/rt: Don't active rt throtting when no running cfs task
Date: Tue, 16 Jun 2020 10:59:00 -0400 [thread overview]
Message-ID: <20200616105900.5cb0671d@oasis.local.home> (raw)
In-Reply-To: <20200616140158.GY2531@hirez.programming.kicks-ass.net>
On Tue, 16 Jun 2020 16:01:58 +0200
Peter Zijlstra <peterz@infradead.org> wrote:
> On Tue, Jun 16, 2020 at 09:50:27AM -0400, Steven Rostedt wrote:
> > On Tue, 16 Jun 2020 20:37:29 +0800
> > Lichao Liu <liulichao@loongson.cn> wrote:
> >
> > > Active rt throtting will dequeue rt_rq from rq at least 50ms,
> > > When there is no running cfs task, do we still active it?
> > >
> >
> > This is something I would like to have.
> >
> > Peter, what's your thought on this?
>
> I'd love to just delete all of this.. that said, I'm not sure this
> change makes sense, because it doesn't deal sanely with the case where
> the task will appear right after we did this.
I haven't looked closely at the surrounding code, but wouldn't it get
throttled in the next period? Do we care if a task has to wait a bit
longer?
>
> The right thing to do is that fair deadline server thing.
But we've been saying that for years now.
-- Steve
next prev parent reply other threads:[~2020-06-16 14:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-16 12:37 [PATCH] sched/rt: Don't active rt throtting when no running cfs task Lichao Liu
2020-06-16 13:50 ` Steven Rostedt
2020-06-16 14:01 ` Peter Zijlstra
2020-06-16 14:59 ` Steven Rostedt [this message]
2020-06-16 17:07 ` Peter Zijlstra
2020-06-16 18:33 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200616105900.5cb0671d@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liulichao@loongson.cn \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox