From: Vladimir Oltean <olteanv@gmail.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, andrew@lunn.ch, vivien.didelot@gmail.com,
f.fainelli@gmail.com, joakim.tjernlund@infinera.com,
madalin.bucur@oss.nxp.com, fido_max@inbox.ru,
linux-kernel@vger.kernel.org
Subject: [PATCH net 0/2] Reapply DSA fix for dpaa-eth with proper Fixes: tag
Date: Tue, 16 Jun 2020 17:41:16 +0300 [thread overview]
Message-ID: <20200616144118.3902244-1-olteanv@gmail.com> (raw)
From: Vladimir Oltean <vladimir.oltean@nxp.com>
Joakim notified me that this breaks stable trees.
It turns out that my assessment about who-broke-who was wrong.
The real Fixes: tag should have been:
Fixes: 060ad66f9795 ("dpaa_eth: change DMA device")
which changes the device on which SET_NETDEV_DEV is made.
git describe --tags 060ad66f97954
v5.4-rc3-783-g060ad66f9795
Which means that it shouldn't have been backported to 4.19 and below.
This series reverts the commit with the misleading commit message, and
reapplies it with a corrected one. The resulting code is exactly the
same, but now, the revert should make it to the stable trees (along with
the bad fix), and the new fix should only make it down to v5.4.y.
Vladimir Oltean (2):
Revert "dpaa_eth: fix usage as DSA master, try 3"
dpaa_eth: fix usage as DSA master, try 4
--
2.25.1
next reply other threads:[~2020-06-16 14:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-16 14:41 Vladimir Oltean [this message]
2020-06-16 14:41 ` [PATCH net 1/2] Revert "dpaa_eth: fix usage as DSA master, try 3" Vladimir Oltean
2020-06-16 14:41 ` [PATCH net 2/2] dpaa_eth: fix usage as DSA master, try 4 Vladimir Oltean
2020-06-16 14:51 ` Joakim Tjernlund
2020-06-16 14:56 ` Vladimir Oltean
2020-06-16 15:04 ` Joakim Tjernlund
2020-06-16 15:08 ` Vladimir Oltean
2020-06-16 15:12 ` Vladimir Oltean
2020-06-16 15:15 ` Joakim Tjernlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200616144118.3902244-1-olteanv@gmail.com \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=fido_max@inbox.ru \
--cc=joakim.tjernlund@infinera.com \
--cc=linux-kernel@vger.kernel.org \
--cc=madalin.bucur@oss.nxp.com \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox