From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Maxim Uvarov <maxim.uvarov@linaro.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"tee-dev @ lists . linaro . org" <tee-dev@lists.linaro.org>,
peterhuewe@gmx.de, Jason Gunthorpe <jgg@ziepe.ca>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jens Wiklander <jens.wiklander@linaro.org>,
linux-integrity@vger.kernel.org, Arnd Bergmann <arnd@linaro.org>,
Sumit Garg <sumit.garg@linaro.org>
Subject: Re: [PATCHv6 1/3] optee: use uuid for sysfs driver entry
Date: Tue, 16 Jun 2020 23:13:43 +0300 [thread overview]
Message-ID: <20200616201343.GE10412@linux.intel.com> (raw)
In-Reply-To: <CAD8XO3b4K6ozHwKf2NDJ482JQY6CPXKKxRuZgo5snP16i_5E=Q@mail.gmail.com>
On Thu, Jun 04, 2020 at 12:16:21PM +0300, Maxim Uvarov wrote:
> On Thu, 4 Jun 2020 at 11:37, Jarkko Sakkinen
> <jarkko.sakkinen@linux.intel.com> wrote:
> >
> > On Mon, Jun 01, 2020 at 06:06:43PM +0300, Maxim Uvarov wrote:
> > > With the evolving use-cases for TEE bus, now it's required to support
> > > multi-stage enumeration process. But using a simple index doesn't
> > > suffice this requirement and instead leads to duplicate sysfs entries.
> > > So instead switch to use more informative device UUID for sysfs entry
> > > like:
> > > /sys/bus/tee/devices/optee-ta-<uuid>
> > >
> > > Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org>
> > > Reviewed-by: Sumit Garg <sumit.garg@linaro.org>
> >
> > Why do you mean by duplicate sysfs entries?
> >
>
> Without this change it will try to register something like that:
> first stage w/o tee-supplicant:
> /sys/bus/tee/devices/optee-clnt0
> /sys/bus/tee/devices/optee-clnt1
> /sys/bus/tee/devices/optee-clnt3
> Then with tee-supplicant also index started with 0. I.e.
> /sys/bus/tee/devices/optee-clnt0
> /sys/bus/tee/devices/optee-clnt1
> ...
>
> So we need to increase global index or use some other unique names.
Got it, thanks.
/Jarkko
next prev parent reply other threads:[~2020-06-16 20:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-01 15:06 [PATCHv6 0/3] optee: register drivers on optee bus Maxim Uvarov
2020-06-01 15:06 ` [PATCHv6 1/3] optee: use uuid for sysfs driver entry Maxim Uvarov
2020-06-04 8:36 ` Jarkko Sakkinen
2020-06-04 9:16 ` Maxim Uvarov
2020-06-16 20:13 ` Jarkko Sakkinen [this message]
2020-06-04 9:21 ` Sumit Garg
2020-06-16 20:15 ` Jarkko Sakkinen
2020-06-01 15:06 ` [PATCHv6 2/3] optee: enable support for multi-stage bus enumeration Maxim Uvarov
2020-06-01 15:06 ` [PATCHv6 3/3] tpm_ftpm_tee: register driver on TEE bus Maxim Uvarov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200616201343.GE10412@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=arnd@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=jens.wiklander@linaro.org \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxim.uvarov@linaro.org \
--cc=peterhuewe@gmx.de \
--cc=sumit.garg@linaro.org \
--cc=tee-dev@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).