Re: [PATCH v6 00/19] The new cgroup slab memory controller

Roman Gushchin
2020-06-18T20:44:05Z

On Thu, Jun 18, 2020 at 12:27:07PM +0300, Mike Rapoport wrote:
> Hi Roman,
>
> On Mon, Jun 08, 2020 at 04:06:35PM -0700, Roman Gushchin wrote:
> > This is v6 of the slab cgroup controller rework.
> >
> > The patchset moves the accounting from the page level to the object
> > level. It allows to share slab pages between memory cgroups.
> > This leads to a significant win in the slab utilization (up to 45%)
> > and the corresponding drop in the total kernel memory footprint.
> > The reduced number of unmovable slab pages should also have a positive
> > effect on the memory fragmentation.
>
> ...
>
> > Johannes Weiner (1):
> > mm: memcontrol: decouple reference counting from page accounting
> >
> > Roman Gushchin (18):
> > mm: memcg: factor out memcg- and lruvec-level changes out of __mod_lruvec_state()
> > mm: memcg: prepare for byte-sized vmstat items
> > mm: memcg: convert vmstat slab counters to bytes
> > mm: slub: implement SLUB version of obj_to_index()
> > mm: memcg/slab: obj_cgroup API
> > mm: memcg/slab: allocate obj_cgroups for non-root slab pages
> > mm: memcg/slab: save obj_cgroup for non-root slab objects
> > mm: memcg/slab: charge individual slab objects instead of pages
> > mm: memcg/slab: deprecate memory.kmem.slabinfo
> > mm: memcg/slab: move memcg_kmem_bypass() to memcontrol.h
> > mm: memcg/slab: use a single set of kmem_caches for all accounted allocations
> > mm: memcg/slab: simplify memcg cache creation
> > mm: memcg/slab: remove memcg_kmem_get_cache()
> > mm: memcg/slab: deprecate slab_root_caches
> > mm: memcg/slab: remove redundant check in memcg_accumulate_slabinfo()
> > mm: memcg/slab: use a single set of kmem_caches for all allocations
> > kselftests: cgroup: add kernel memory accounting tests
> > tools/cgroup: add memcg_slabinfo.py tool
>
> Sorry for jumping late, but I'm really missing
>
> Documentation/vm/cgroup-slab.rst | < lots of + >
>
> in this series ;-)

Hi Mike!

That's a good point. I'll write something and send a separate patch.
Changes are barely visible to a user, so no rush here,
but it's definitely a good idea to document the new design.

Thank you!