From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 103CDC433E0 for ; Wed, 17 Jun 2020 11:17:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E932620734 for ; Wed, 17 Jun 2020 11:17:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727028AbgFQLRm (ORCPT ); Wed, 17 Jun 2020 07:17:42 -0400 Received: from elvis.franken.de ([193.175.24.41]:35916 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727012AbgFQLRi (ORCPT ); Wed, 17 Jun 2020 07:17:38 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1jlW4P-0006Ho-02; Wed, 17 Jun 2020 13:17:29 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 43C36C06C3; Wed, 17 Jun 2020 13:14:04 +0200 (CEST) Date: Wed, 17 Jun 2020 13:14:03 +0200 From: Thomas Bogendoerfer To: maobibo Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] MIPS: Do not flush tlb when setting pmd entry Message-ID: <20200617111403.GC9940@alpha.franken.de> References: <1591177333-17833-1-git-send-email-maobibo@loongson.cn> <20200615101443.GA10075@alpha.franken.de> <4bef403d-baba-ddf8-c25c-3d6968897a53@loongson.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4bef403d-baba-ddf8-c25c-3d6968897a53@loongson.cn> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 16, 2020 at 06:34:21PM +0800, maobibo wrote: > > > On 06/15/2020 06:14 PM, Thomas Bogendoerfer wrote: > > On Wed, Jun 03, 2020 at 05:42:13PM +0800, Bibo Mao wrote: > >> Function set_pmd_at is to set pmd entry, if tlb entry need to > >> be flushed, there exists pmdp_huge_clear_flush alike function > >> before set_pmd_at is called. So it is not necessary to call > >> flush_tlb_all in this function. > > > > have you checked all set_pmd_at() calls ? I found a few case where > > it's not clear to me, if tlb flushing is done... If you think this > > is still the right thing to do, please change arch/mips/mm/pgtable-32.c > > as well. > well, I will double check this and do more testing about thp and hugepage. I was more concerned about fs/dax.c fs/proc/task_mmu.c mm/rmap.c Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]