Re: Re: [PATCH v2] staging: gasket: core: Fix a coding style issue in gasket_core.c

Dan Carpenter
2020-07-15T11:26:06Z

On Wed, Jul 15, 2020 at 06:45:21PM +0800, Zhao wrote:
> At 2020-07-15 17:04:06, "Joe Perches" <joe@perches.com> wrote:
> >On Wed, 2020-07-15 at 11:37 +0300, Dan Carpenter wrote:
> >> On Wed, Jul 15, 2020 at 09:57:55AM +0200, Greg KH wrote:
> >> > On Wed, Jul 15, 2020 at 12:24:22AM -0700, Joe Perches wrote:
> >> > > On Wed, 2020-07-15 at 09:17 +0200, Greg KH wrote:
> >> > > > On Wed, Jul 15, 2020 at 07:44:40AM +0800, Zhixu Zhao wrote:
> >> > > > > On Thu, Jun 18, 2020 at 12:11:27AM +0800, Zhixu Zhao wrote:
> >> > > > > > A coding alignment issue is found by checkpatch.pl.
> >> > > > > > Fix it by using a temporary for gasket_dev->bar_data[bar_num].
> >> > > > > >
> >> > > > > > Signed-off-by: Zhixu Zhao <zhixu001@126.com>
> >> > > > >
> >> > > > > Hi, there~
> >> > > > >
> >> > > > > Does anybody have any further comments on this?
> >> > > > > Can it be merged?
> >> > > >
> >> > > > I never saw the first version of this, are you sure it got sent to the
> >> > > > mailing list? It's not in any archives anywhere.
> >> > >
> >> > > I saw it. It's here:
> >> > > https://lore.kernel.org/lkml/20200617161127.32006-1-zhixu001@126.com/
> >> >
> >> > Ah, doh, sorry.
> >> >
> >> > Zhixu, please address the comments given to you on the series and resend
> >> > it as a new version.
> >>
> >> He responded but not as a reply to my email. It turns out I made a
> >> mistake.
> >>
> >> Anyway, just resend, Zhixu.
> >
> >It's a pity a resend is being requested.
> >
> >It'd be a better process if the original patch could
> >be applied via the link akin to a git pull.
> >
>
> Yes. All comments have been resolved by now. Patch v2 is sufficient.
>
> As Dan said, there was a tailing thread because I mis-replied his mail.
> I just now replied that mail with a reference to the final resolution mail.

Just resend.

regards,
dan carpenter