From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 354EBC433DF for ; Wed, 17 Jun 2020 23:58:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E38EB20882 for ; Wed, 17 Jun 2020 23:58:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="oA+imnl5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726906AbgFQX6W (ORCPT ); Wed, 17 Jun 2020 19:58:22 -0400 Received: from rnd-relay.smtp.broadcom.com ([192.19.229.170]:38650 "EHLO rnd-relay.smtp.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726763AbgFQX6W (ORCPT ); Wed, 17 Jun 2020 19:58:22 -0400 Received: from mail-irv-17.broadcom.com (mail-irv-17.lvn.broadcom.net [10.75.242.48]) by rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id D897430D81D; Wed, 17 Jun 2020 16:58:20 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com D897430D81D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com; s=dkimrelay; t=1592438300; bh=MDbwOv/n/PjcbExKhgCfJsNvpgg8GqIQ00OSvsMrBO0=; h=From:To:Cc:Subject:Date:From; b=oA+imnl5pndLVvXvkjMdmUndxBg8m7nUe+ml+6CCyBHK7tvwKwVv1HnzcZduX5wyp IrlnyMirbBkkypJeUFt+jIby2nzdCF8NsOH3T33oBYj1pkOfklYWWEDvZu9JmYKaZ6 OgrY1ORsS+07QUu8NH5KMfE3sa0WPZtbWjlEGPLg= Received: from lbrmn-mmayer.ric.broadcom.net (lbrmn-mmayer.ric.broadcom.net [10.136.28.150]) by mail-irv-17.broadcom.com (Postfix) with ESMTP id 26BED14008B; Wed, 17 Jun 2020 16:58:20 -0700 (PDT) From: Markus Mayer To: Daniel Lezcano , Sumeet Pawnikar , Zhang Rui , Brian Norris Cc: Markus Mayer , Broadcom Kernel List , Linux Kernel Mailing List Subject: [PATCH] tools/thermal: tmon: include pthread and time headers in tmon.h Date: Wed, 17 Jun 2020 16:58:08 -0700 Message-Id: <20200617235809.6817-1-mmayer@broadcom.com> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Include sys/time.h and pthread.h in tmon.h, so that types "pthread_mutex_t" and "struct timeval tv" are known when tmon.h references them. Without these headers, compiling tmon against musl-libc will fail with these errors: In file included from sysfs.c:31:0: tmon.h:47:8: error: unknown type name 'pthread_mutex_t' extern pthread_mutex_t input_lock; ^~~~~~~~~~~~~~~ make[3]: *** [: sysfs.o] Error 1 make[3]: *** Waiting for unfinished jobs.... In file included from tui.c:31:0: tmon.h:54:17: error: field 'tv' has incomplete type struct timeval tv; ^~ make[3]: *** [: tui.o] Error 1 make[2]: *** [Makefile:83: tmon] Error 2 Signed-off-by: Markus Mayer --- The issue was discovered cross-compiling tmon for aarch64 with musl-libc. The build succeeds with glibc, because the required headers are included implicitly. This is not the case with musl-libc. tools/thermal/tmon/tmon.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/thermal/tmon/tmon.h b/tools/thermal/tmon/tmon.h index c9066ec104dd..44d16d778f04 100644 --- a/tools/thermal/tmon/tmon.h +++ b/tools/thermal/tmon/tmon.h @@ -27,6 +27,9 @@ #define NR_LINES_TZDATA 1 #define TMON_LOG_FILE "/var/tmp/tmon.log" +#include +#include + extern unsigned long ticktime; extern double time_elapsed; extern unsigned long target_temp_user; -- 2.17.1