From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D06CC433E1 for ; Thu, 18 Jun 2020 02:17:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 02F8F214DB for ; Thu, 18 Jun 2020 02:17:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592446649; bh=MoCoYLtzTgCSVAz2/r0y8tvFO6qxhoeFPk4SIUOnq/I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=autGPZPQF/fqn4VPV/zZu8dGEFUieBN8W1fF+Uo4bxDhxpObCEJpq15VGGCKYPONq x6iPLOU55agMYlg3Ud8Zk8EUBQTF6EAtaN/zxxAgcIFaF+Gp67os0p3KlGPHIkq7hK 5lUMKjTm0ypD1fQHi4+jlDyieM9CsqjTZu+7AqxQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730178AbgFRCRR (ORCPT ); Wed, 17 Jun 2020 22:17:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:52082 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730232AbgFRBUA (ORCPT ); Wed, 17 Jun 2020 21:20:00 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CE7B521D90; Thu, 18 Jun 2020 01:19:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592443200; bh=MoCoYLtzTgCSVAz2/r0y8tvFO6qxhoeFPk4SIUOnq/I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wZagrJ717goVqFqenMElE8mmNuS0sLzPXBGVz+GhZPlYt13GLwOIRX0zu/HK+X4CV Q9HSrVhf/IYTWtopFXHnxSJs+Mm2IFLt8tJjNp1aHw75fh/o8pZCg7K5T1WrgS1UG4 6Z0U6QVBxdQf4ySomgwVB6UJ5fKb2+iLZixkFi58= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Gregory CLEMENT , Greg Kroah-Hartman , Sasha Levin Subject: [PATCH AUTOSEL 5.4 159/266] tty: n_gsm: Fix bogus i++ in gsm_data_kick Date: Wed, 17 Jun 2020 21:14:44 -0400 Message-Id: <20200618011631.604574-159-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200618011631.604574-1-sashal@kernel.org> References: <20200618011631.604574-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Gregory CLEMENT [ Upstream commit 4dd31f1ffec6c370c3c2e0c605628bf5e16d5c46 ] When submitting the previous fix "tty: n_gsm: Fix waking up upper tty layer when room available". It was suggested to switch from a while to a for loop, but when doing it, there was a remaining bogus i++. This patch removes this i++ and also reorganizes the code making it more compact. Fixes: e1eaea46bb40 ("tty: n_gsm line discipline") Signed-off-by: Gregory CLEMENT Link: https://lore.kernel.org/r/20200518084517.2173242-3-gregory.clement@bootlin.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/tty/n_gsm.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c index 8a0d66a05af5..75408b9f232d 100644 --- a/drivers/tty/n_gsm.c +++ b/drivers/tty/n_gsm.c @@ -703,17 +703,9 @@ static void gsm_data_kick(struct gsm_mux *gsm, struct gsm_dlci *dlci) } else { int i = 0; - for (i = 0; i < NUM_DLCI; i++) { - struct gsm_dlci *dlci; - - dlci = gsm->dlci[i]; - if (dlci == NULL) { - i++; - continue; - } - - tty_port_tty_wakeup(&dlci->port); - } + for (i = 0; i < NUM_DLCI; i++) + if (gsm->dlci[i]) + tty_port_tty_wakeup(&gsm->dlci[i]->port); } } } -- 2.25.1