From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DE77C433DF for ; Thu, 18 Jun 2020 01:48:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 107432070A for ; Thu, 18 Jun 2020 01:48:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592444935; bh=q19YoOPcNO2IN83jRjeKuamRK9v5O7H+ShDLmX4IZJ8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=bAjHXWmCcqSuTq9tlwBpOXYCNIt1kD4Y47XBmM2uCxgkyHAb394V4xA5NN/T/f+Rb Ablmrypj85OcT6wOxgouAbK3vWgWzXe0MFwpPBFQ/lHdPy0kJkfmZ49041SU+09Sc5 sShs/6guRU2C40Jc6U40APXiiSckPzlbTsoBj6eI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731952AbgFRB1s (ORCPT ); Wed, 17 Jun 2020 21:27:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:59048 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731206AbgFRBY2 (ORCPT ); Wed, 17 Jun 2020 21:24:28 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B104F21974; Thu, 18 Jun 2020 01:24:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592443468; bh=q19YoOPcNO2IN83jRjeKuamRK9v5O7H+ShDLmX4IZJ8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dTyaH3/ZOS4fTkX3f1z5xBB6ieucBJSRxCG7L9Cqq2rrGyDv6tK0Sk75k/FLkrMjQ 3Gs5xWTznuH7k3iB1rVQCHgeMLJK3nsNySOd/Nu3MP5n/wXalszAhTwNGIvDRM45sq 6b/RL/5ahQ7UAY0pVXAni3Dwifitu7x9LSBpLyJA= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Gregory CLEMENT , Greg Kroah-Hartman , Sasha Levin Subject: [PATCH AUTOSEL 4.19 100/172] tty: n_gsm: Fix bogus i++ in gsm_data_kick Date: Wed, 17 Jun 2020 21:21:06 -0400 Message-Id: <20200618012218.607130-100-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200618012218.607130-1-sashal@kernel.org> References: <20200618012218.607130-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Gregory CLEMENT [ Upstream commit 4dd31f1ffec6c370c3c2e0c605628bf5e16d5c46 ] When submitting the previous fix "tty: n_gsm: Fix waking up upper tty layer when room available". It was suggested to switch from a while to a for loop, but when doing it, there was a remaining bogus i++. This patch removes this i++ and also reorganizes the code making it more compact. Fixes: e1eaea46bb40 ("tty: n_gsm line discipline") Signed-off-by: Gregory CLEMENT Link: https://lore.kernel.org/r/20200518084517.2173242-3-gregory.clement@bootlin.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/tty/n_gsm.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c index 166052002b79..5e9457d19927 100644 --- a/drivers/tty/n_gsm.c +++ b/drivers/tty/n_gsm.c @@ -703,17 +703,9 @@ static void gsm_data_kick(struct gsm_mux *gsm, struct gsm_dlci *dlci) } else { int i = 0; - for (i = 0; i < NUM_DLCI; i++) { - struct gsm_dlci *dlci; - - dlci = gsm->dlci[i]; - if (dlci == NULL) { - i++; - continue; - } - - tty_port_tty_wakeup(&dlci->port); - } + for (i = 0; i < NUM_DLCI; i++) + if (gsm->dlci[i]) + tty_port_tty_wakeup(&gsm->dlci[i]->port); } } } -- 2.25.1