From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2904C433DF for ; Thu, 18 Jun 2020 01:49:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7918822201 for ; Thu, 18 Jun 2020 01:49:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592444944; bh=0V7dE6479ka7p+b1cgEb56ZJP10pjJxIG98AhJLSwms=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=j1ScgW+PIlNz8vZCqSJCDHuVUpp4rZBmOoTKFI2WRgQc2Z1djOtBI1fGUQ22YJCya ryB8eFWbe9gyfU/cZrI7TuF2ceXZfUNE81fDK0mAXHiw2KhohZIK1UiFBY3d9mV8Ga hz8MQ7X9N6kIl2L1Mk6CMF4UrAVcBUKsRSyFmlkE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731941AbgFRB1r (ORCPT ); Wed, 17 Jun 2020 21:27:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:59008 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731199AbgFRBY1 (ORCPT ); Wed, 17 Jun 2020 21:24:27 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 675B0221EC; Thu, 18 Jun 2020 01:24:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592443467; bh=0V7dE6479ka7p+b1cgEb56ZJP10pjJxIG98AhJLSwms=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IK5Y1HXefTpPyLrjCzv7zokiywmNexBa6o9/59jnkoj+qSouMZQT2ulqoADiAY2Zy CAGZDdO5tdxhjFNfw/BzY6S9jOAFUYBvGZ6B3KzD5HRsT4Ar8ahjp26+qFBp6EFfBn 7zbcPEDHOlBGKelm80UUxR65RfQFDO5g2Y1MHTgY= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Tang Bin , Zhang Shengju , Peter Chen , Greg Kroah-Hartman , Sasha Levin , linux-usb@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 099/172] USB: host: ehci-mxc: Add error handling in ehci_mxc_drv_probe() Date: Wed, 17 Jun 2020 21:21:05 -0400 Message-Id: <20200618012218.607130-99-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200618012218.607130-1-sashal@kernel.org> References: <20200618012218.607130-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tang Bin [ Upstream commit d49292025f79693d3348f8e2029a8b4703be0f0a ] The function ehci_mxc_drv_probe() does not perform sufficient error checking after executing platform_get_irq(), thus fix it. Fixes: 7e8d5cd93fac ("USB: Add EHCI support for MX27 and MX31 based boards") Signed-off-by: Zhang Shengju Signed-off-by: Tang Bin Reviewed-by: Peter Chen Link: https://lore.kernel.org/r/20200513132647.5456-1-tangbin@cmss.chinamobile.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/host/ehci-mxc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/host/ehci-mxc.c b/drivers/usb/host/ehci-mxc.c index c9f91e6c72b6..7f65c86047dd 100644 --- a/drivers/usb/host/ehci-mxc.c +++ b/drivers/usb/host/ehci-mxc.c @@ -50,6 +50,8 @@ static int ehci_mxc_drv_probe(struct platform_device *pdev) } irq = platform_get_irq(pdev, 0); + if (irq < 0) + return irq; hcd = usb_create_hcd(&ehci_mxc_hc_driver, dev, dev_name(dev)); if (!hcd) -- 2.25.1