Re: [PATCH AUTOSEL 4.19 047/172] ASoC: meson: add missing free_irq() in error path

Pavel Machek
2020-06-19T13:28:43Z

[-- Attachment #1: Type: text/plain, Size: 801 bytes --]

Hi!

> From: "Pavel Machek (CIP)" <pavel@denx.de>
>
> [ Upstream commit 3b8a299a58b2afce464ae11324b59dcf0f1d10a7 ]
>
> free_irq() is missing in case of error, fix that.
>
> Signed-off-by: Pavel Machek (CIP) <pavel@denx.de>
> Reviewed-by: Jerome Brunet <jbrunet@baylibre.com>
>
> Link: https://lore.kernel.org/r/20200606153103.GA17905@amd
> Signed-off-by: Mark Brown <broonie@kernel.org>

Notice that the bug this fixes is theoretical (found by code review)
and the fix itself was not tested by me as I don't have the hardware.

It may be good idea to for mainline to test the change a bit...

Best regards,
Pavel

--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]