From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFD4AC433E0 for ; Thu, 18 Jun 2020 01:49:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BA356221F6 for ; Thu, 18 Jun 2020 01:49:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592444978; bh=ycZ0ABT4QoiUOZLPu2kdhV+mHvmuwufpb1hj4VzyrQA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=NvH/S1uno9231vw10scIEY62b9icr0Beqy204kY48Dd9ZXMK/mBMrBWc1kwzHYdtK iW7BGxYBH0pZNbyO8PTjRP85NUskvvJdB2iLJWApAOveXq7vf9mKEdyXIkS8qWugbn XU4Wv6YUblW3RwXPPZZIuXsmsL1M1GwsXkeSx1h4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733182AbgFRBtf (ORCPT ); Wed, 17 Jun 2020 21:49:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:35832 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729855AbgFRB1h (ORCPT ); Wed, 17 Jun 2020 21:27:37 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C849B221F3; Thu, 18 Jun 2020 01:27:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592443657; bh=ycZ0ABT4QoiUOZLPu2kdhV+mHvmuwufpb1hj4VzyrQA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aDYybvK/NxApFXTlGzhcRMsLDfwIwePeni2a+BM3Ds6WZuvhASPux3sK2E/xuJUeP q+i5vvcEwzc07BySSK2EBwJFXBdXR2RWSXgSV3SBwuCJpFnqpLA951gNsno9m1uMCS +uModXMYM3LYwfW1IeHycwQeH5Cqiu4kof2YHoeU= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Qiushi Wu , Felipe Balbi , Sasha Levin , linux-usb@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 076/108] usb: gadget: fix potential double-free in m66592_probe. Date: Wed, 17 Jun 2020 21:25:28 -0400 Message-Id: <20200618012600.608744-76-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200618012600.608744-1-sashal@kernel.org> References: <20200618012600.608744-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Qiushi Wu [ Upstream commit 44734a594196bf1d474212f38fe3a0d37a73278b ] m66592_free_request() is called under label "err_add_udc" and "clean_up", and m66592->ep0_req is not set to NULL after first free, leading to a double-free. Fix this issue by setting m66592->ep0_req to NULL after the first free. Fixes: 0f91349b89f3 ("usb: gadget: convert all users to the new udc infrastructure") Signed-off-by: Qiushi Wu Signed-off-by: Felipe Balbi Signed-off-by: Sasha Levin --- drivers/usb/gadget/udc/m66592-udc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/udc/m66592-udc.c b/drivers/usb/gadget/udc/m66592-udc.c index 46ce7bc15f2b..53abad98af6d 100644 --- a/drivers/usb/gadget/udc/m66592-udc.c +++ b/drivers/usb/gadget/udc/m66592-udc.c @@ -1672,7 +1672,7 @@ static int m66592_probe(struct platform_device *pdev) err_add_udc: m66592_free_request(&m66592->ep[0].ep, m66592->ep0_req); - + m66592->ep0_req = NULL; clean_up3: if (m66592->pdata->on_chip) { clk_disable(m66592->clk); -- 2.25.1