From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DDB5C433E0 for ; Thu, 18 Jun 2020 01:36:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DD5582192A for ; Thu, 18 Jun 2020 01:36:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592444185; bh=yCRVey+nAv7CIq0CFCedLwQzMoecpsVb5CjrPPKWTbw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=xX6+gb+pMB2q2xXzWGbxjWqkmmbkS2RMBNtuFuxKnZ0p7r0k3u1SmoRUW2FiHb+/I 7j8sA9F3l8nqPuTy7AfJhd6nEGiySAfzfMr6vQ9FlDdQUf2ux57K2+ETQH/5UidMWj bJ7K6jdf2JrVtQ+8ZjQPkZIEgRelj3PFVxbtlhgs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732707AbgFRBbG (ORCPT ); Wed, 17 Jun 2020 21:31:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:36246 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731973AbgFRB1w (ORCPT ); Wed, 17 Jun 2020 21:27:52 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 65B6622200; Thu, 18 Jun 2020 01:27:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592443672; bh=yCRVey+nAv7CIq0CFCedLwQzMoecpsVb5CjrPPKWTbw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EHhgGbwTuQ0S3+Zv4pb8s4/bNb2qSsJGRV+tBIK9ojB7NVm69TMKGthU/ROW+jQxU aL3iSt/hNxiSIcBmVrz32+O94vKqveU5gurcP5Yz0ABD9tgU86Nq/U79vBU6BEBRmD 3JQ5KpvccoMGVCXrccJoxEQTlOiQ8cuPskzF5AyI= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Stafford Horne , Sasha Levin , openrisc@lists.librecores.org Subject: [PATCH AUTOSEL 4.14 088/108] openrisc: Fix issue with argument clobbering for clone/fork Date: Wed, 17 Jun 2020 21:25:40 -0400 Message-Id: <20200618012600.608744-88-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200618012600.608744-1-sashal@kernel.org> References: <20200618012600.608744-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Stafford Horne [ Upstream commit 6bd140e14d9aaa734ec37985b8b20a96c0ece948 ] Working on the OpenRISC glibc port I found that sometimes clone was working strange. That the tls data argument sent in r7 was always wrong. Further investigation revealed that the arguments were getting clobbered in the entry code. This patch removes the code that writes to the argument registers. This was likely due to some old code hanging around. This patch fixes this up for clone and fork. This fork clobber is harmless but also useless so remove. Signed-off-by: Stafford Horne Signed-off-by: Sasha Levin --- arch/openrisc/kernel/entry.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/openrisc/kernel/entry.S b/arch/openrisc/kernel/entry.S index 1107d34e45bf..0fdfa7142f4b 100644 --- a/arch/openrisc/kernel/entry.S +++ b/arch/openrisc/kernel/entry.S @@ -1102,13 +1102,13 @@ ENTRY(__sys_clone) l.movhi r29,hi(sys_clone) l.ori r29,r29,lo(sys_clone) l.j _fork_save_extra_regs_and_call - l.addi r7,r1,0 + l.nop ENTRY(__sys_fork) l.movhi r29,hi(sys_fork) l.ori r29,r29,lo(sys_fork) l.j _fork_save_extra_regs_and_call - l.addi r3,r1,0 + l.nop ENTRY(sys_rt_sigreturn) l.jal _sys_rt_sigreturn -- 2.25.1