From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BED0C433DF for ; Thu, 18 Jun 2020 07:12:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E8EF321532 for ; Thu, 18 Jun 2020 07:12:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="bdT4Jipg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728095AbgFRHMV (ORCPT ); Thu, 18 Jun 2020 03:12:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44126 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727115AbgFRHMV (ORCPT ); Thu, 18 Jun 2020 03:12:21 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32B7DC06174E for ; Thu, 18 Jun 2020 00:12:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=fOQMFX0QqLMTbV6VegdwBRvYgy6RQf+xn1lfJSvvlA8=; b=bdT4JipgnI08pFeV28vEL5pwh3 aeUMEBhHWrawbflbmfy53u1UsZZp/tQz3aCqNUdBdqJhyKXdXHx98w4s3PnETcR6ExGhJFakiGhFP P2Lw9ScRH9Fo+fIgPjKjS1IqE3P7F7WRRKDmEKHloIs56H2A3DrhHndw9u2JmYSIitqzCDxe+vfJa HQFNxoqz2X1bfWSuTTmyqqtRMLIV8fE0LFBLXunJupzuBaTFsblnfVzW4OpVkxelkjVX6/KSIg7FZ ME37a1Be3X8DZuWlFzvKVrY8WQgJecfbq5KKG4ey53hcKpjNDyXBE5jkXxeeXm9xPzFp5DRl9FpwP 5wqIuoSg==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jloiU-0002mN-Nu; Thu, 18 Jun 2020 07:12:06 +0000 Date: Thu, 18 Jun 2020 00:12:06 -0700 From: Christoph Hellwig To: Fenghua Yu Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Peter Zijlstra , H Peter Anvin , David Woodhouse , Lu Baolu , Dave Hansen , Tony Luck , Jean-Philippe Brucker , Christoph Hellwig , Ashok Raj , Jacob Jun Pan , Dave Jiang , Sohil Mehta , Ravi V Shankar , iommu@lists.linux-foundation.org, x86 , linux-kernel Subject: Re: [PATCH v3 01/13] iommu: Change type of pasid to unsigned int Message-ID: <20200618071206.GA7294@infradead.org> References: <1592418233-17762-1-git-send-email-fenghua.yu@intel.com> <1592418233-17762-2-git-send-email-fenghua.yu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1592418233-17762-2-git-send-email-fenghua.yu@intel.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 17, 2020 at 11:23:41AM -0700, Fenghua Yu wrote: > PASID is defined as a few different types in iommu including "int", > "u32", and "unsigned int". To be consistent and to match with ioasid's > type, define PASID and its variations (e.g. max PASID) as "unsigned int". Wouldn't u32 be a little more explicit (besides being shorter and matching the uapi definitions)?