Re: [Linux] [PATCH] Kernel selftests: tpm2: upgrade tpm2 tests from python2 to python3

Pengfei Xu
2020-06-18T07:41:19Z

Hi Jarkko,
Thanks for your advice.
My feedback is as below.

BR.
Thanks!

On 2020-06-18 at 10:18:58 +0300, Jarkko Sakkinen wrote:
> On Thu, Jun 18, 2020 at 11:02:45AM +0800, Pengfei Xu wrote:
> > Some Linux OS will never support python2 anymore, so upgrade tpm2 selftests
> > to python3.
> >
> > Signed-off-by: Pengfei Xu <pengfei.xu@intel.com>
>
> Linux is a kernel, not a full operating system. Perhaps you mean Linux
> distributions?
>

Will remove [Linux], thanks!

> Please capitalize abbrevations correctly (TPM2, not tpm2). Please write
> 'Python 2' instead of python2.
>

Will do, thanks!

> With that said the commit message is inaccurate. The root reason for
> moving to Python 3 is that Python 2 is no longer supported by the Python
> upstream project. Nothing to do with Linux or Linux distributions for
> that matter.
>
Will do, thanks!

> /Jarkko