From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7346BC433E0 for ; Thu, 18 Jun 2020 08:15:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4E2E820773 for ; Thu, 18 Jun 2020 08:15:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OeeHyY+Y" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728512AbgFRIPX (ORCPT ); Thu, 18 Jun 2020 04:15:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728398AbgFRIPV (ORCPT ); Thu, 18 Jun 2020 04:15:21 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B09D8C061755 for ; Thu, 18 Jun 2020 01:15:20 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id e1so5045482wrt.5 for ; Thu, 18 Jun 2020 01:15:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=VFAtsOIUbu3lSU/HEGGn9hrUEMDItq984a8uDB0vTG4=; b=OeeHyY+YKwWr2fRsYI11CjIJOMFFkdCm85UynZj7MpMoE9cp+TT0NoE8bPVmdKNSzf QTIAlb3B23TkGeN9VzxVOhsSJ1N47FjHc0HndFsFSgJunxiS3u/Xh0o6KkKOngoTOzQK mzSxMd7ej+ALbFugboPDoWizoX/iKpXRGYPK3I0cDW7KYMWWo/cVVI1DplpNBfOTrIFJ DFKek/jSOY2zOffnNr75HeaTp4uUyeotKBquwFBZwQTL7NIrn/D+1UUorehTACtmSScG 6RsxLv6wCrP/2KFNpXHu95CoxXxBW3VT/5dUcI4iHiTz4sZF8UAEIQVnrQPCBO+p7cdT 5kzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=VFAtsOIUbu3lSU/HEGGn9hrUEMDItq984a8uDB0vTG4=; b=SfkLtiChDmJRuqWqczu3QPzNa4Gd4F46chdhYK0xufHSdhSXtrT+0d9kcPZRqRlCxM NbwEgmu2uIwKD2PID6S1X5QK5wyuaq/de0mNcIqwNML6D5ldysECVInFYopc3AFI/fxf 0G96Vky9NOkHvwEgXbhB7PkYdQ3i0Y7NxQfX0v3cKvcIr43a87VzjgSoo3ZEgXxEJzgV Zmxpi80Wz5K+XP6b5A+feKzcSab9+o+4nEcBXUAZAWMQekIx4i7sgbN6jSBJ1TixC7Yy Q+oCtG7HzetqMyUwjUxDwhBX3NyMaAV6kw3IC3lf6lb8VfUj6e8U4vgbIfoDh0ai4vGH PRAA== X-Gm-Message-State: AOAM5328VWvSY+nV+PqIi4aHJC44urnQf8Lfx973vafISuQ/KO+sMysy xuCy3qrdAyXF9O/9kefOwKaIpQ== X-Google-Smtp-Source: ABdhPJw7v4a6RUSX4JeAquXGtY8pIltUKnas1QX4AmwEVUOoZpZugP52IHFdKrlL7jAb5gwUMH7j6A== X-Received: by 2002:a5d:6809:: with SMTP id w9mr3485714wru.182.1592468119418; Thu, 18 Jun 2020 01:15:19 -0700 (PDT) Received: from dell ([95.149.164.118]) by smtp.gmail.com with ESMTPSA id h203sm2112690wme.37.2020.06.18.01.15.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jun 2020 01:15:18 -0700 (PDT) Date: Thu, 18 Jun 2020 09:15:17 +0100 From: Lee Jones To: Neil Armstrong Cc: linux-amlogic@lists.infradead.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/5] mfd: add support for the Khadas System control Microcontroller Message-ID: <20200618081517.GA2608702@dell> References: <20200608091739.2368-1-narmstrong@baylibre.com> <20200608091739.2368-3-narmstrong@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200608091739.2368-3-narmstrong@baylibre.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 08 Jun 2020, Neil Armstrong wrote: > This Microcontroller is present on the Khadas VIM1, VIM2, VIM3 and Edge > boards. > > It has multiple boot control features like password check, power-on > options, power-off control and system FAN control on recent boards. > > This implements a very basic MFD driver with the fan control and User > NVMEM cells. > > Signed-off-by: Neil Armstrong > --- A patch-level change log makes reviewing easier. > drivers/mfd/Kconfig | 21 +++++ > drivers/mfd/Makefile | 1 + > drivers/mfd/khadas-mcu.c | 142 +++++++++++++++++++++++++++++++++ > include/linux/mfd/khadas-mcu.h | 91 +++++++++++++++++++++ > 4 files changed, 255 insertions(+) > create mode 100644 drivers/mfd/khadas-mcu.c > create mode 100644 include/linux/mfd/khadas-mcu.h Nicely done. Applied, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog