Re: [PATCH v3 0/5] mfd: Add support for Khadas Microcontroller

Neil Armstrong
2020-06-18T09:39:21Z

Hi,

On 18/06/2020 10:19, Lee Jones wrote:
> On Mon, 08 Jun 2020, Neil Armstrong wrote:
>
>> The new Khadas VIM2, VIM3 and Edge boards embeds an on-board microcontroller
>> connected via I2C.
>>
>> This Microcontroller is present on the Khadas VIM1, VIM2, VIM3 and Edge
>> boards.
>>
>> It has multiple boot control features like password check, power-on
>> options, power-off control and system FAN control on recent boards.
>>
>> Thie serie adds :
>> - the bindings
>> - the MFD driver
>> - the Thermal Cooling cell driver
>> - updates MAINTAINERS
>> - add support into the Khadas VIM3/VIM3L DT
>>
>> Changes since v2 at [3]:
>> - Removed NVMEM driver for separate submission
>> - fixed MFD driver, header and Kconfig
>> - fixed Thermal Kconfig
>> - fixed MAINTAINERS files and path
>>
>> Changes since RFC v1 at [2]:
>> - moved hwmon driver to thermal-only
>> - moved the SM1 thermal nodes in a separate serie
>> - added the bindings review tag from rob
>>
>> [1] http://lore.kernel.org/r/20200512093916.19676-1-narmstrong@baylibre.com
>> [2] http://lore.kernel.org/r/20200421080102.22796-1-narmstrong@baylibre.com
>> [3] http://lore.kernel.org/r/20200512132613.31507-1-narmstrong@baylibre.com
>>
>> Neil Armstrong (5):
>> dt-bindings: mfd: add Khadas Microcontroller bindings
>> mfd: add support for the Khadas System control Microcontroller
>> thermal: add support for the MCU controlled FAN on Khadas boards
>> MAINTAINERS: add myself as maintainer for Khadas MCU drivers
>> arm64: dts: meson-khadas-vim3: add Khadas MCU nodes
>
> I'm a bit concerned by the missing patches from my inbox.

Oops sorry, I'll resend the full serie with you in CC

>
> Looks like you omitted to send me patch 3 and 5.
>
> Hopefully the Thermal patch doesn't depend on the MFD one!

It does ! It includes the include/linux/mfd/khadas-mcu.h file

Amit reviewed the thermal patches already.

Neil

>
>> .../devicetree/bindings/mfd/khadas,mcu.yaml | 44 +++++
>> MAINTAINERS | 9 +
>> .../boot/dts/amlogic/meson-khadas-vim3.dtsi | 23 +++
>> drivers/mfd/Kconfig | 21 +++
>> drivers/mfd/Makefile | 1 +
>> drivers/mfd/khadas-mcu.c | 142 ++++++++++++++
>> drivers/thermal/Kconfig | 11 ++
>> drivers/thermal/Makefile | 1 +
>> drivers/thermal/khadas_mcu_fan.c | 174 ++++++++++++++++++
>> include/linux/mfd/khadas-mcu.h | 91 +++++++++
>> 10 files changed, 517 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/mfd/khadas,mcu.yaml
>> create mode 100644 drivers/mfd/khadas-mcu.c
>> create mode 100644 drivers/thermal/khadas_mcu_fan.c
>> create mode 100644 include/linux/mfd/khadas-mcu.h
>>
>