Re: [PATCH v6 05/19] mm: memcontrol: decouple reference counting from page accounting

Roman Gushchin
2020-06-18T19:52:14Z

On Thu, Jun 18, 2020 at 07:55:35AM -0700, Shakeel Butt wrote:
> Not sure if my email went through, so, re-sending.

No, I've got it, jut was busy with the other stuff.

>
> On Mon, Jun 8, 2020 at 4:07 PM Roman Gushchin <guro@fb.com> wrote:
> >
> > From: Johannes Weiner <hannes@cmpxchg.org>
> >
> [...]
> > @@ -3003,13 +3004,16 @@ void __memcg_kmem_uncharge_page(struct page *page, int order)
> > */
> > void mem_cgroup_split_huge_fixup(struct page *head)
> > {
> > + struct mem_cgroup *memcg = head->mem_cgroup;
> > int i;
> >
> > if (mem_cgroup_disabled())
> > return;
> >
>
> A memcg NULL check is needed here.

Thanks for the heads up!

I'll double check it and send a follow-up fix.